Attachment 94622 Details for Bug 23843 – Bug 23843: Add mapping to Koha::Club::Holds

[patch] Bug 23843: Add mapping to Koha::Club::Holds

Bug-23843-Add-mapping-to-KohaClubHolds.patch (text/plain), 2.46 KB, created by Joonas Kylmälä on 2019-10-23 14:11:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2019-10-23 14:11:55 UTC

Size: 2.46 KB

patch

obsolete

>From b415fb5192382870eded85ccb76d2c4cea833b76 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 21 Oct 2019 13:25:34 -0300
>Subject: [PATCH] Bug 23843: Add mapping to Koha::Club::Holds
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch adds a to_api_mapping method to the class. This in effect
>enables calling ->to_api on the object. The mapping is borrowed from the
>API controller. It is not removed from the controller so we are able to
>verify (through the tests) that there is no behavior change.
>Once this is pushed we need to implement the counter-wise methods and
>clean the controllers.
>To test:
>1. Run:
>   $ kshell
>  k$ prove t/db_dependent/api/v1/clubs_holds.t
>=> SUCCESS: Tests pass
>2. Apply this patch
>3. Repeat (1)
>=> SUCCESS: Tests still pass!
>4. Sign off :-D
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@helsinki.fi>
>---
> Koha/Club/Hold.pm           | 25 ++++++++++++++++++++++---
> Koha/REST/V1/Clubs/Holds.pm |  7 ++++---
> 2 files changed, 26 insertions(+), 6 deletions(-)
>
>diff --git a/Koha/Club/Hold.pm b/Koha/Club/Hold.pm
>index 9ca8f40456..b8b78fb293 100644
>--- a/Koha/Club/Hold.pm
>+++ b/Koha/Club/Hold.pm
>@@ -40,7 +40,7 @@ Represents a hold made for every member of club
> 
> =head1 API
> 
>-=head2 Class Methods
>+=head2 Class methods
> 
> =cut
> 
>@@ -125,7 +125,26 @@ sub add {
> 
> }
> 
>-=head3 type
>+
>+=head3 to_api_mapping
>+
>+This method returns the mapping for representing a Koha::Club::Hold object
>+on the API.
>+
>+=cut
>+
>+sub to_api_mapping {
>+    return {
>+        id        => 'club_hold_id',
>+        club_id   => 'club_id',
>+        biblio_id => 'biblio_id',
>+        item_id   => 'item_id'
>+    };
>+}
>+
>+=head2 Internal methods
>+
>+=head3 _type
> 
> =cut
> 
>@@ -139,4 +158,4 @@ Agustin Moyano <agustinmoyano@theke.io>
> 
> =cut
> 
>-1;
>\ No newline at end of file
>+1;
>diff --git a/Koha/REST/V1/Clubs/Holds.pm b/Koha/REST/V1/Clubs/Holds.pm
>index 5d25bd3c5f..6b061dca66 100644
>--- a/Koha/REST/V1/Clubs/Holds.pm
>+++ b/Koha/REST/V1/Clubs/Holds.pm
>@@ -119,9 +119,10 @@ sub add {
>             item_type => $item_type
>         });
> 
>-        my $mapping = _to_api($club_hold->unblessed);
>-
>-        return $c->render( status => 201, openapi => $mapping );
>+        return $c->render(
>+            status  => 201,
>+            openapi => $club_hold->to_api
>+        );
>     }
>     catch {
>         if ( blessed $_ and $_->isa('Koha::Exceptions::Object') ) {
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 23843: 94470 | 94471 | 94472 | 94473 | 94474 | 94475 | 94476 | 94477 | 94478 | 94496 | 94506 | 94507 | 94508 | 94509 | 94510 | 94511 | 94512 | 94513 | 94514 | 94587 | 94588 | 94589 | 94590 | 94591 | 94592 | 94593 | 94594 | 94595 | 94596 | 94619 | 94620 | 94621 | 94622 | 94623 | 94624 | 94625 | 94626 | 94627 | 94628