Bugzilla – Attachment 94664 Details for
Bug 23838
Add ability to view item renew history
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23838: (follow-up) Fix JS strings
Bug-23838-follow-up-Fix-JS-strings.patch (text/plain), 2.35 KB, created by
Andrew Isherwood
on 2019-10-24 13:11:06 UTC
(
hide
)
Description:
Bug 23838: (follow-up) Fix JS strings
Filename:
MIME Type:
Creator:
Andrew Isherwood
Created:
2019-10-24 13:11:06 UTC
Size:
2.35 KB
patch
obsolete
>From 91052aed56bb152508f2b8a69452a3b3234dcfbe Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Thu, 24 Oct 2019 14:07:37 +0100 >Subject: [PATCH] Bug 23838: (follow-up) Fix JS strings > >As requested by Owen in comment #7 > >Owen, I have modified the "x out y renewals have been logged" formation >as you suggested. The "Renewed on x by y" string is harder because it >contains markup and I suspected the strings file should contain such >things. I have however very slightly reworded it which will hopefully >mean it's structure is suitable for other languages too. >--- > .../intranet-tmpl/prog/en/includes/patron-renewal-modal-strings.inc | 6 ++---- > koha-tmpl/intranet-tmpl/prog/js/patron-renewal-modal.js | 2 +- > 2 files changed, 3 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-renewal-modal-strings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-renewal-modal-strings.inc >index c13e6bb8b7..f0727183db 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-renewal-modal-strings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-renewal-modal-strings.inc >@@ -1,7 +1,5 @@ > <script> >- var note = _("Note"); >- var out_of = _("out of"); >- var renewals_logged = _("renewals have been logged") >- var renewed_on = _("Renewed on"); >+ var renewed_prop = _("Note: %s out of %s renewals have been logged"); >+ var renewed_on = _("Renewed"); > var by = _("by"); > </script> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/patron-renewal-modal.js b/koha-tmpl/intranet-tmpl/prog/js/patron-renewal-modal.js >index 21733feca7..4323190817 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/patron-renewal-modal.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/patron-renewal-modal.js >@@ -11,7 +11,7 @@ $(document).ready(function(){ > $('#patronRenewals #retrieving').show(); > $.get('/api/v1/patrons/'+patronid+'/renewals?item_id='+itemid+'&embed=patron,renewed_by', function(data) { > if (data.length < renewals) { >- $('#patronRenewals #incomplete').append(note + ': ' + data.length + ' ' + out_of + ' ' + renewals + ' ' + renewals_logged).show(); >+ $('#patronRenewals #incomplete').append(renewed_prop.format(data.length, renewals)).show(); > } > var items = data.map(function(item) { > return createLi(item); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23838
:
94394
|
94395
|
94635
|
94636
|
94663
|
94664
|
94676
|
94681
|
94682
|
94683
|
94684
|
94685
|
95466
|
95467
|
95468
|
95469
|
95470
|
95471
|
95472
|
96186
|
96187
|
96188
|
96189
|
96190
|
131892
|
131914
|
131915
|
133945
|
133946
|
133966
|
133967
|
133968
|
134890
|
134891
|
134892
|
137167
|
137168
|
137169
|
138007
|
138019
|
138020
|
138021
|
138022
|
138039
|
138040
|
138041
|
138042
|
138043