Bugzilla – Attachment 94747 Details for
Bug 23579
error during web install: 'changed_fields' can't have a default value
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23579: (RM follow-up) Fix failing tests
Bug-23579-RM-follow-up-Fix-failing-tests.patch (text/plain), 2.10 KB, created by
Martin Renvoize (ashimema)
on 2019-10-25 12:13:55 UTC
(
hide
)
Description:
Bug 23579: (RM follow-up) Fix failing tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-10-25 12:13:55 UTC
Size:
2.10 KB
patch
obsolete
>From 14e5d38773027cd424d7bb3385804d06740097ad Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 25 Oct 2019 13:12:38 +0100 >Subject: [PATCH] Bug 23579: (RM follow-up) Fix failing tests > >Removing the default on changed_fields leads to the requirement for >tests to specify data to add to said field when mocking data. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Letters/TemplateToolkit.t | 2 +- > t/db_dependent/Members.t | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Letters/TemplateToolkit.t b/t/db_dependent/Letters/TemplateToolkit.t >index 502e4299cc..f62a737eb9 100644 >--- a/t/db_dependent/Letters/TemplateToolkit.t >+++ b/t/db_dependent/Letters/TemplateToolkit.t >@@ -97,7 +97,7 @@ my $serial = Koha::Serial->new()->store(); > my $subscription = Koha::Subscription->new()->store(); > my $suggestion = Koha::Suggestion->new()->store(); > my $checkout = Koha::Checkout->new( { itemnumber => $item->id() } )->store(); >-my $modification = Koha::Patron::Modification->new( { verification_token => "TEST" } )->store(); >+my $modification = Koha::Patron::Modification->new( { verification_token => "TEST", changed_fields => 'firstname,surname' } )->store(); > > my $prepared_letter; > >diff --git a/t/db_dependent/Members.t b/t/db_dependent/Members.t >index dbda295dda..ff5fe994ff 100755 >--- a/t/db_dependent/Members.t >+++ b/t/db_dependent/Members.t >@@ -341,7 +341,7 @@ subtest 'purgeSelfRegistration' => sub { > my $d=360; > C4::Members::DeleteUnverifiedOpacRegistrations($d); > foreach(1..3) { >- $dbh->do("INSERT INTO borrower_modifications (timestamp, borrowernumber, verification_token) VALUES ('2014-01-01 01:02:03',0,?)", undef, (scalar localtime)."_$_"); >+ $dbh->do("INSERT INTO borrower_modifications (timestamp, borrowernumber, verification_token, changed_fields) VALUES ('2014-01-01 01:02:03',0,?,'firstname,surname')", undef, (scalar localtime)."_$_"); > } > is( C4::Members::DeleteUnverifiedOpacRegistrations($d), 3, 'Test for DeleteUnverifiedOpacRegistrations' ); > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23579
:
94716
|
94718
| 94747