Attachment 94802 Details for Bug 23655 – Bug 23655: Restore debian Jessie support

[patch] Bug 23655: Restore debian Jessie support

Bug-23655-Restore-debian-Jessie-support.patch (text/plain), 1.67 KB, created by Martin Renvoize (ashimema) on 2019-10-26 11:08:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-10-26 11:08:19 UTC

Size: 1.67 KB

patch

obsolete

>From 8387d6a2d242c4b60e858c5a42574ec7928f3ecf Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Sat, 26 Oct 2019 11:58:18 +0100
>Subject: [PATCH] Bug 23655: Restore debian Jessie support
>
>Bug 14570 inadveratntly introduced the use of selectall_array; A feature
>that was introduced to DBI version 1.635 which is not available in
>debian jessie at the time of writing.
>
>This patch replaces the call with selectall_arrayref which is supported
>and works with the rest of the existing code.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> about.pl | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/about.pl b/about.pl
>index 31b30db170..14be586170 100755
>--- a/about.pl
>+++ b/about.pl
>@@ -474,12 +474,12 @@ $template->param( 'bad_yaml_prefs' => \@bad_yaml_prefs ) if @bad_yaml_prefs;
> 
>     $bad_relationships_count = $bad_relationships_count->[0]->[0];
> 
>-    my @existing_relationships = $dbh->selectall_array(q{
>-        SELECT DISTINCT(relationship)
>-        FROM (
>-            SELECT relationship FROM borrower_relationships WHERE relationship IS NOT NULL
>-            UNION ALL
>-            SELECT relationship FROM borrowers WHERE relationship IS NOT NULL) a
>+    my @existing_relationships = $dbh->selectall_arrayref(q{
>+          SELECT DISTINCT(relationship)
>+          FROM (
>+              SELECT relationship FROM borrower_relationships WHERE relationship IS NOT NULL
>+              UNION ALL
>+              SELECT relationship FROM borrowers WHERE relationship IS NOT NULL) a
>     });
> 
>     my %valid_relationships = map { $_ => 1 } split( /,|\|/, C4::Context->preference('borrowerRelationship') );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23655: 93138 | 94802