Bugzilla – Attachment 94836 Details for
Bug 23594
Add ability to batch modify itemtypes from the suggestions page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23594: Restore previous view after delete or update itemtype
Bug-23594-Restore-previous-view-after-delete-or-up.patch (text/plain), 2.91 KB, created by
Séverine Queune
on 2019-10-29 14:04:27 UTC
(
hide
)
Description:
Bug 23594: Restore previous view after delete or update itemtype
Filename:
MIME Type:
Creator:
Séverine Queune
Created:
2019-10-29 14:04:27 UTC
Size:
2.91 KB
patch
obsolete
>From a980af85a6b8487918b7595a14e87b13ddd53043 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 22 Oct 2019 12:00:18 +0200 >Subject: [PATCH] Bug 23594: Restore previous view after delete or update > itemtype >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >We want to restore the previous view when suggestions are deleted or >their itemtypes are updated. >To avoid c/p the code is moved to a new subroutine. > >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> >--- > suggestion/suggestion.pl | 36 +++++++++++++++++++++--------------- > 1 file changed, 21 insertions(+), 15 deletions(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index 9653e69..011a54d 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -224,25 +224,12 @@ elsif ($op eq "update_status" ) { > $suggestion->{suggestionid} = $suggestionid; > &ModSuggestion($suggestion); > } >- my $params = ''; >- foreach my $key ( >- qw( >- displayby branchcode title author isbn publishercode copyrightdate >- collectiontitle suggestedby suggesteddate_from suggesteddate_to >- manageddate_from manageddate_to accepteddate_from >- accepteddate_to budgetid >- ) >- ) >- { >- $params .= $key . '=' . uri_escape($input->param($key)) . '&' >- if defined($input->param($key)); >- } >- print $input->redirect("/cgi-bin/koha/suggestion/suggestion.pl?$params"); >+ redirect_with_params($input); > }elsif ($op eq "delete" ) { > foreach my $delete_field (@editsuggestions) { > &DelSuggestion( $borrowernumber, $delete_field,'intranet' ); > } >- $op = 'else'; >+ redirect_with_params($input); > } > elsif ( $op eq 'update_itemtype' ) { > my $new_itemtype = $input->param('suggestion_itemtype'); >@@ -250,6 +237,7 @@ elsif ( $op eq 'update_itemtype' ) { > next unless $suggestionid; > &ModSuggestion({ suggestionid => $suggestionid, itemtype => $new_itemtype }); > } >+ redirect_with_params($input); > } > elsif ( $op eq 'show' ) { > $suggestion_ref=&GetSuggestion($$suggestion_ref{'suggestionid'}); >@@ -413,3 +401,21 @@ $template->param( > SuggestionStatuses => GetAuthorisedValues('SUGGEST_STATUS'), > ); > output_html_with_http_headers $input, $cookie, $template->output; >+ >+sub redirect_with_params { >+ my ( $input ) = @_; >+ my $params = ''; >+ foreach my $key ( >+ qw( >+ displayby branchcode title author isbn publishercode copyrightdate >+ collectiontitle suggestedby suggesteddate_from suggesteddate_to >+ manageddate_from manageddate_to accepteddate_from >+ accepteddate_to budgetid >+ ) >+ ) >+ { >+ $params .= $key . '=' . uri_escape(scalar $input->param($key)) . '&' >+ if defined($input->param($key)); >+ } >+ print $input->redirect("/cgi-bin/koha/suggestion/suggestion.pl?$params"); >+} >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23594
:
94469
|
94520
|
94521
|
94834
|
94835
|
94836
|
97663
|
97664
|
97665
|
97693
|
97781
|
98094
|
98095
|
98096
|
98097
|
98098
|
98099