Attachment 94873 Details for Bug 23836 – Bug 23836: exit after output_error

[patch] Bug 23836: exit after output_error

Bug-23836-exit-after-outputerror.patch (text/plain), 989 bytes, created by Jonathan Druart on 2019-10-30 12:16:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-10-30 12:16:14 UTC

Size: 989 bytes

patch

obsolete

>From 6977aad03a713f50b6437a9591bff69b529c07d8 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 30 Oct 2019 13:15:38 +0100
>Subject: [PATCH] Bug 23836: exit after output_error
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> opac/tracklinks.pl | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/opac/tracklinks.pl b/opac/tracklinks.pl
>index 80794cb50d..2c0d213617 100755
>--- a/opac/tracklinks.pl
>+++ b/opac/tracklinks.pl
>@@ -34,7 +34,10 @@ my $biblionumber = $cgi->param('biblionumber') || 0;
> my $itemnumber   = $cgi->param('itemnumber')   || 0;
> 
> my $tracking_method = C4::Context->preference('TrackClicks');
>-output_error( $cgi, '404' ) unless $tracking_method;
>+unless ( $tracking_method ) {
>+    output_error( $cgi, '404' );
>+    exit;
>+}
> my $tracker = Koha::Linktracker->new(
>     { trackingmethod => $tracking_method } );
> if ($uri && ($biblionumber || $itemnumber) ) {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23836: 94376 | 94872 | 94873 | 94935 | 94936