Bugzilla – Attachment 94910 Details for
Bug 22706
Add plugin hooks to allow custom password strength checking modules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22706: (RM follow-up) Add unit tests
Bug-22706-RM-follow-up-Add-unit-tests.patch (text/plain), 3.58 KB, created by
Martin Renvoize (ashimema)
on 2019-10-31 12:22:11 UTC
(
hide
)
Description:
Bug 22706: (RM follow-up) Add unit tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-10-31 12:22:11 UTC
Size:
3.58 KB
patch
obsolete
>From a9bdeac01a732d29d32c0c6519bea3c835b49784 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 31 Oct 2019 12:21:01 +0000 >Subject: [PATCH] Bug 22706: (RM follow-up) Add unit tests > >Helps if one actually adds the new test file to the commit! > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Koha/Plugins/Patron.t | 86 ++++++++++++++++++++++++++++ > 1 file changed, 86 insertions(+) > create mode 100644 t/db_dependent/Koha/Plugins/Patron.t > >diff --git a/t/db_dependent/Koha/Plugins/Patron.t b/t/db_dependent/Koha/Plugins/Patron.t >new file mode 100644 >index 0000000000..b3378974ae >--- /dev/null >+++ b/t/db_dependent/Koha/Plugins/Patron.t >@@ -0,0 +1,86 @@ >+#!/usr/bin/perl >+ >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 3 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, see <http://www.gnu.org/licenses>. >+ >+use Modern::Perl; >+ >+use Test::More tests => 5; >+use Test::Exception; >+ >+use File::Basename; >+ >+use C4::Items; >+ >+use t::lib::Mocks; >+use t::lib::TestBuilder; >+ >+BEGIN { >+ # Mock pluginsdir before loading Plugins module >+ my $path = dirname(__FILE__) . '/../../../lib'; >+ t::lib::Mocks::mock_config( 'pluginsdir', $path ); >+ >+ use_ok('Koha::Plugins'); >+ use_ok('Koha::Plugins::Handler'); >+ use_ok('Koha::Plugin::Test'); >+ use_ok('Koha::Patron'); >+} >+ >+my $schema = Koha::Database->new->schema; >+my $builder = t::lib::TestBuilder->new; >+ >+t::lib::Mocks::mock_preference( 'UseKohaPlugins', 1 ); >+t::lib::Mocks::mock_config( 'enable_plugins', 1 ); >+ >+subtest 'check_password hook tests' => sub { >+ >+ plan tests => 5; >+ >+ $schema->storage->txn_begin; >+ >+ my $plugins = Koha::Plugins->new; >+ $plugins->InstallPlugins; >+ >+ my $plugin = Koha::Plugin::Test->new->enable; >+ >+ my $library = $builder->build( { source => 'Branch' } ); >+ my $category = $builder->build( { source => 'Category' } ); >+ my $patron = Koha::Patron->new( >+ { >+ cardnumber => 'test_cn_1', >+ branchcode => $library->{branchcode}, >+ categorycode => $category->{categorycode}, >+ surname => 'surname for patron1', >+ firstname => 'firstname for patron1', >+ userid => 'a_nonexistent_userid_1', >+ password => "exploder", >+ } >+ ); >+ >+ throws_ok { $patron->store } 'Koha::Exceptions::Password::Plugin', >+ 'Exception raised for adding patron with bad password'; >+ $patron->password('1234'); >+ ok( $patron->store, 'Patron created with good password' ); >+ >+ t::lib::Mocks::mock_preference( 'RequireStrongPassword', '0' ); >+ throws_ok { $patron->set_password({ password => 'explosion' }) } 'Koha::Exceptions::Password::Plugin', >+ 'Exception raised for update patron password with bad string'; >+ ok( $patron->set_password({ password => '4321' }), 'Patron password updated with good string' ); >+ ok( $patron->set_password({ password => 'explosion', skip_validation => 1}), 'Patron password updated via skip validation'); >+ >+ $schema->storage->txn_rollback; >+ Koha::Plugins::Methods->delete; >+}; >+ >+1; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22706
:
93488
|
93526
|
94613
|
94614
|
94672
|
94673
|
94674
|
94675
|
94905
|
94906
|
94907
| 94910