Attachment 9492 Details for Bug 8048 – [SIGNED-OFF] Bug 8048 - better spacing on categories for attributes

[patch] [SIGNED-OFF] Bug 8048 - better spacing on categories for attributes

SIGNED-OFF-Bug-8048---better-spacing-on-categories.patch (text/plain), 2.83 KB, created by Nicole C. Engard on 2012-05-09 17:10:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicole C. Engard

Created: 2012-05-09 17:10:37 UTC

Size: 2.83 KB

patch

obsolete

>From 31d4dbf2cacaacd3aebddc728f1e4e1e402ab680 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 9 May 2012 12:28:58 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 8048 - better spacing on categories for attributes
>
> - Convert <h4> to <caption> and adding comfortable padding.
> - Add quotes to attribute for validity
> - Add padding to patron messaging note too since it has
>   the same problem.
>
>To test you must have at least one value added to the PA_CLASS
>authorised value category. At least one patron attribute must
>be categorized using that value.
>
>On the patron edit screen that patron attribute category should
>display with comfortable padding.
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>
>Looks much better!
>---
> .../intranet-tmpl/prog/en/css/staff-global.css     |    8 ++++++++
> .../prog/en/modules/members/memberentrygen.tt      |    6 +++---
> 2 files changed, 11 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>index 68523d7..338b768 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>@@ -692,6 +692,14 @@ fieldset.rows ol.radio label.radio {
> 	margin-right : 1em;
> }
> 
>+fieldset.rows caption {
>+    font-size : 120%;
>+}
>+
>+fieldset.rows p {
>+    margin : 1em 0 1em 1em;
>+}
>+
> fieldset.rows table {
> 	font-size : 105%;
> 	clear : both;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index bc1f07c..0cb2877 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -1384,8 +1384,8 @@
>     <legend>Additional attributes and identifiers</legend>
>     [% FOREACH pa_loo IN patron_attributes %]
>         [% IF pa_loo.class %]
>-            <h4>[% pa_loo.lib %]</h4>
>-            <table id=aai_[% pa_loo.class %] class="attributes_table">
>+            <table id="aai_[% pa_loo.class %]" class="attributes_table">
>+            <caption>[% pa_loo.lib %]</caption>
>         [% ELSE %]
>             <table id="aai" class="attributes_table">
>         [% END %]
>@@ -1497,7 +1497,7 @@
>     <input type="hidden" name="setting_messaging_prefs" value="1" />
>     <legend id="patron_messaging_prefs_lgd">Patron messaging preferences</legend>
>     [% IF type_only %]
>-        <i>If no preferences are selected, the default preferences for the category chosen will be applied on save, otherwise your selection here is saved</i>
>+        <p>If no preferences are selected, the default preferences for the category chosen will be applied on save, otherwise your selection here is saved</p>
>     [% END %]
>     [% INCLUDE 'messaging-preference-form.inc' %]
>     [% IF ( SMSSendDriver ) %]
>-- 
>1.7.2.3

Actions: View | Diff | Splinter Review

Attachments on bug 8048: 9423 | 9490 | 9492