Attachment 94937 Details for Bug 22814 – Bug 22814: Make patron names on holds modal consistent (second check-in)

[patch] Bug 22814: Make patron names on holds modal consistent (second check-in)

Bug-22814-Make-patron-names-on-holds-modal-consist.patch (text/plain), 2.60 KB, created by Marcel de Rooy on 2019-11-01 08:42:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2019-11-01 08:42:09 UTC

Size: 2.60 KB

patch

obsolete

>From bb38f0ca232147b688a4415080bc74d694240080 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Thu, 10 Oct 2019 12:53:10 +0000
>Subject: [PATCH] Bug 22814: Make patron names on holds modal consistent
> (second check-in)
>Content-Type: text/plain; charset=utf-8
>
>Bug 22203 changed the behavior on the hold-found2 modal
>that pops up when a hold is found so that whether or not
>the patron's name is displayed is now governed by the
>HidePatronName system preference.
>
>However, if a hold is confirmed and you check the item
>in a second time, the modal that pops up is hold-found1
>and whether or not the patron's name is displayed in
>the hold-found1 modal is not governed by the HidePatronName
>system preference.
>
>For the sake of consistency, the display of the patron's
>name on hold-found2 and hold-found1 should both be governed
>by the HidePatronName system preference.
>
>To test:
>- Place a hold on an item
>- Check in the item to trigger the hold modal
>- Confirm hold
>- Check the item in again - verify name of patron displays
>- Apply patch
>- Repeat
>- Verify name display now matches between the two modals
>- change HidePatronName pref
>- Repeat
>- Name display should still match
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index faf05d52f2..bafaf0e955 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -420,7 +420,7 @@
>                                                     <h4>Hold for:</h4>
>                                                     <ul>
>                                                         <li>
>-                                                            <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% patron.borrowernumber | uri %]">[% patron.surname | html %], [% patron.firstname | html %]</a> ([% patron.cardnumber | html %])
>+                                                            [% INCLUDE 'patron-title.inc' patron=patron hide_patron_infos_if_needed=1 link_to="circulation_reserves" %]
>                                                             <span class="patron-category"> - [% patron.category.description | html %]</span>
>                                                         </li>
>                                                         [% INCLUDE display_holdpatron_address %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22814: 94104 | 94213 | 94937