Bugzilla – Attachment 95017 Details for
Bug 23964
An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23964: ReservesNeedReturn shoudl only apply to available items
Bug-23964-ReservesNeedReturn-shoudl-only-apply-to-.patch (text/plain), 1.71 KB, created by
Nick Clemens (kidclamp)
on 2019-11-04 16:10:00 UTC
(
hide
)
Description:
Bug 23964: ReservesNeedReturn shoudl only apply to available items
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2019-11-04 16:10:00 UTC
Size:
1.71 KB
patch
obsolete
>From b90196c47977b89b4e5038ab98be7a17c5c7be41 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 4 Nov 2019 16:06:15 +0000 >Subject: [PATCH] Bug 23964: ReservesNeedReturn shoudl only apply to available > items > >To test: > 1 - Checkout an item to a patron > 2 - Make sure 'ReservesNeedReturn' is set to 'Automatically' > 3 - Place an item level hold on the checked out item > 4 - Note the hold is marked waiting > 5 - Delete the hold > 6 - Apply patch > 7 - Place a new hold > 8 - Hold is not marked waiting > 9 - Please a hold on a different item >10 - Note it is marked waiting >11 - Test when item is damaged and hold not allowed on damaged items >12 - Test when item is in transit >13 - Test when item has another hold >14 - Only in the case where none of the above are true should the hold be marked waiting >--- > C4/Reserves.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index cf6ee50169..b9fb57b5c4 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -173,9 +173,9 @@ sub AddReserve { > # if we have an item selectionned, and the pickup branch is the same as the holdingbranch > # of the document, we force the value $priority and $found . > if ( $checkitem and not C4::Context->preference('ReservesNeedReturns') ) { >- $priority = 0; > my $item = Koha::Items->find( $checkitem ); # FIXME Prevent bad calls >- if ( $item->holdingbranch eq $branch ) { >+ if ( !$item->onloan && $item->holdingbranch eq $branch && ( $item->damaged && C4::Context->preference('AllowHoldsOnDamagedItems') || !$item->damaged ) && !$item->get_transfer && !$item->holds->count ) { >+ $priority = 0; > $found = 'W'; > } > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23964
:
95016
|
95017
|
95021
|
95022
|
95111
|
95249
|
95544
|
95594
|
95595
|
95596
|
95597
|
95598
|
95599
|
95639
|
95640
|
95641
|
95642
|
95643
|
95644
|
95780
|
95781