Bugzilla – Attachment 95023 Details for
Bug 23774
When placing a hold editing using Inspect Element allows addition to the code of non listed library
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23774: Server-side confirmation for hold pickup location in OPAC
Bug-23774-Server-side-confirmation-for-hold-pickup.patch (text/plain), 2.12 KB, created by
Martin Renvoize (ashimema)
on 2019-11-04 17:15:14 UTC
(
hide
)
Description:
Bug 23774: Server-side confirmation for hold pickup location in OPAC
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-11-04 17:15:14 UTC
Size:
2.12 KB
patch
obsolete
>From ff264bc2dfad582fef452fbde70df02e1a195ad9 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@hypernova.fi> >Date: Mon, 4 Nov 2019 16:32:58 +0000 >Subject: [PATCH] Bug 23774: Server-side confirmation for hold pickup location > in OPAC > >While placing a hold on a book, if a user opens up Inspect Element on the >Pick up location drop down box they can change the pick up location in >the code to a library that is not listed as a pick up location. > >How to replicate: >Search for a book >Select book >Click Place Hold > >On the screen Home > Placing a hold > >Right click on Pick up location >Select 'Inspect Element' > >Under ><!-- HOLDABLE --> > ><li class="Branch"> ><select name="Branch ******"> Pick Up location:</label>=$0 > >Option values are listed that relate to the pick up location, this value >can be changed to another new location and when the hold is placed >the hold will be placed for this new location instead of the listed options >in the Pick up location drop down list. > >To test: >1. Apply patch >2. Repeat "How to replicate" >3. Observe it is no longer possible to place holds on libraries not defined > as pickup location by changing option value via Inspect Element tool > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > opac/opac-reserve.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index 56c5bc2695..b57aae7914 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -274,10 +274,10 @@ if ( $query->param('place_reserve') ) { > > my $rank = $biblioData->{rank}; > if ( $itemNum ne '' ) { >- $canreserve = 1 if CanItemBeReserved( $borrowernumber, $itemNum )->{status} eq 'OK'; >+ $canreserve = 1 if CanItemBeReserved( $borrowernumber, $itemNum, $branch )->{status} eq 'OK'; > } > else { >- $canreserve = 1 if CanBookBeReserved( $borrowernumber, $biblioNum )->{status} eq 'OK'; >+ $canreserve = 1 if CanBookBeReserved( $borrowernumber, $biblioNum, $branch )->{status} eq 'OK'; > > # Inserts a null into the 'itemnumber' field of 'reserves' table. > $itemNum = undef; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23774
:
95018
|
95023
|
95041