Attachment 9509 Details for Bug 7788 – Bug 7788: Patch for addbybiblio scripts

[patch] Bug 7788: Patch for addbybiblio scripts

0002-Bug-7788-SIGNED-OFF-Followup-GetShelf-call-in-addbyb.patch (text/plain), 2.25 KB, created by Jonathan Druart on 2012-05-11 08:53:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2012-05-11 08:53:24 UTC

Size: 2.25 KB

patch

obsolete

>From 698188f22ee3b814eb8d1462ce0af046e208f519 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 22 Mar 2012 11:03:19 +0100
>Subject: [PATCH 2/2] Bug 7788: [SIGNED-OFF] Followup: GetShelf call in
> addbybiblio script corrected
>
>Patch resolves incorrect call to GetShelf in opac and staff. It was and is harmless, because the singlecategory variable was not really used (the category$x param was ignored in the template). Just a cleanup operation.
>
>signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> opac/opac-addbybiblionumber.pl      |    3 +--
> virtualshelves/addbybiblionumber.pl |    3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/opac/opac-addbybiblionumber.pl b/opac/opac-addbybiblionumber.pl
>index b1a460e..6069e76 100755
>--- a/opac/opac-addbybiblionumber.pl
>+++ b/opac/opac-addbybiblionumber.pl
>@@ -115,12 +115,11 @@ sub HandleShelfNumber {
> sub HandleSelectedShelf {
>     if($authorized= ShelfPossibleAction( $loggedinuser, $selectedshelf, 'add')){
>         #adding to specific shelf
>-        my ($singleshelf, $singleshelfname, $singlecategory)= GetShelf($query->param('selectedshelf'));
>+        my ($singleshelf, $singleshelfname)= GetShelf($query->param('selectedshelf'));
>         $template->param(
>         singleshelf               => 1,
>         shelfnumber               => $singleshelf,
>         shelfname                 => $singleshelfname,
>-        "category$singlecategory" => 1
>         );
>     }
> }
>diff --git a/virtualshelves/addbybiblionumber.pl b/virtualshelves/addbybiblionumber.pl
>index d039e42..5fd82b3 100755
>--- a/virtualshelves/addbybiblionumber.pl
>+++ b/virtualshelves/addbybiblionumber.pl
>@@ -161,12 +161,11 @@ sub HandleShelfNumber {
> sub HandleSelectedShelf {
>     if($authorized= ShelfPossibleAction( $loggedinuser, $shelfnumber, 'add')){
>         #confirm adding to specific shelf
>-        my ($singleshelf, $singleshelfname, $singlecategory)= GetShelf($shelfnumber);
>+        my ($singleshelf, $singleshelfname)= GetShelf($shelfnumber);
>         $template->param(
>         singleshelf               => 1,
>         shelfnumber               => $singleshelf,
>         shelfname                 => $singleshelfname,
>-        "category$singlecategory" => 1
>         );
>     }
>     else {
>-- 
>1.7.7.3
>

Actions: View | Diff | Splinter Review

Attachments on bug 7788: 8477 | 8478 | 8481 | 9508 | 9509