Bugzilla – Attachment 95093 Details for
Bug 23467
Duplicated screen if error in opac-reserve.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23467: Exit after output_html - opac-reserve.pl
Bug-23467-Exit-after-outputhtml---opac-reservepl.patch (text/plain), 2.27 KB, created by
Jonathan Druart
on 2019-11-06 10:01:13 UTC
(
hide
)
Description:
Bug 23467: Exit after output_html - opac-reserve.pl
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-11-06 10:01:13 UTC
Size:
2.27 KB
patch
obsolete
>From f4cfe315fec74a6bdfc4216edc5f25e4b2449ed0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 6 Nov 2019 10:59:26 +0100 >Subject: [PATCH] Bug 23467: Exit after output_html - opac-reserve.pl > >To avoid double screen > >There are several ways to recreate the issue, the easiest is: > /cgi-bin/koha/opac-reserve.pl?biblionumber= > >You should see "ERROR: No record id specified." >--- > opac/opac-reserve.pl | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index 56c5bc2695..075ff7491e 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -90,6 +90,7 @@ if ( $patron->category->effective_BlockExpiredPatronOpacActions ) { > # cannot reserve, their card has expired and the rules set mean this is not allowed > $template->param( message => 1, expired_patron => 1 ); > output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 }; >+ exit; > } > } > >@@ -116,6 +117,7 @@ if (! $biblionumbers) { > if ((! $biblionumbers) && (! $query->param('place_reserve'))) { > $template->param(message=>1, no_biblionumber=>1); > output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 }; >+ exit; > } > > # Pass the numbers to the page so they can be fed back >@@ -128,6 +130,7 @@ if (($#biblionumbers < 0) && (! $query->param('place_reserve'))) { > # TODO: New message? > $template->param(message=>1, no_biblionumber=>1); > output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 }; >+ exit; > } > > >@@ -220,6 +223,7 @@ if ( $query->param('place_reserve') ) { > if (($selectionCount == 0) || (($selectionCount % 3) != 0)) { > $template->param(message=>1, bad_data=>1); > output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 }; >+ exit; > } > > my $failed_holds = 0; >@@ -408,6 +412,7 @@ foreach my $biblioNum (@biblionumbers) { > if (! $biblioData) { > $template->param(message=>1, bad_biblionumber=>$biblioNum); > output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 }; >+ exit; > } > > my @not_available_at = (); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23467
:
92249
|
92271
|
95093
|
95097