Bugzilla – Attachment 95121 Details for
Bug 23293
OPACFineNoRenewals always compares against 'balance' not 'outstanding'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23293: Add system preference
Bug-23293-Add-system-preference.patch (text/plain), 3.27 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-11-06 18:48:47 UTC
(
hide
)
Description:
Bug 23293: Add system preference
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-11-06 18:48:47 UTC
Size:
3.27 KB
patch
obsolete
>From c1a5eb6c21fb6ce0bccb955f54004e4c27571b44 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 10 Jul 2019 14:34:47 +0100 >Subject: [PATCH] Bug 23293: Add system preference > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > installer/data/mysql/atomicupdate/bug_23293.perl | 11 +++++++++++ > installer/data/mysql/sysprefs.sql | 1 + > .../prog/en/modules/admin/preferences/opac.pref | 6 ++++++ > 3 files changed, 18 insertions(+) > create mode 100644 installer/data/mysql/atomicupdate/bug_23293.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_23293.perl b/installer/data/mysql/atomicupdate/bug_23293.perl >new file mode 100644 >index 0000000000..092985087e >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_23293.perl >@@ -0,0 +1,11 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ $dbh->do( q{ >+ INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES >+ ('OPACFineNoRenewalsIncludeCredits','1',NULL,'If enabled the value specified in OPACFineNoRenewals should include any unapplied account credits in the calculation','YesNo') >+ }); >+ >+ # Always end with this (adjust the bug info) >+ SetVersion( $DBversion ); >+ print "Upgrade to $DBversion done (Bug 23293 - Add 'OPACFineNoRenewalsIncludeCredits' system preference)\n"; >+} >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 86514d94f9..0743be71d4 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -457,6 +457,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('OpenURLResolverURL', '', NULL, 'URL of OpenURL Resolver', 'Free'), > ('OpenURLText', '', NULL, 'Text of OpenURL links (or image title if OpenURLImageLocation is defined)', 'Free'), > ('OpenURLImageLocation', '', NULL, 'Location of image for OpenURL links', 'Free'), >+('OPACFineNoRenewalsIncludeCredits','1',NULL,'If enabled the value specified in OPACFineNoRenewals should include any unapplied account credits in the calculation','YesNo'), > ('OPACShowOpenURL', '', NULL, 'Enable display of OpenURL links in OPAC search results and detail page', 'YesNo'), > ('OPACOpenURLItemTypes', '', NULL, 'Show the OpenURL link only for these item types', 'Free'), > ('OrderPdfFormat','pdfformat::layout3pages','Controls what script is used for printing (basketgroups)','','free'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >index 82214b4746..e268558f45 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >@@ -625,6 +625,12 @@ OPAC: > - pref: OPACFineNoRenewals > class: currency > - '[% local_currency %] in fines (leave blank to disable).' >+ - >+ - pref: OPACFineNoRenewalsIncludeCredits >+ choices: >+ yes: Include >+ no: "Don't include" >+ - outstanding/unapplied credits when applying the OPACFineNoRenewals rule to users > - > - pref: OPACViewOthersSuggestions > choices: >-- >2.24.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23293
:
91448
|
91449
|
93149
|
93150
|
93151
|
95121
|
95122
|
95123
|
95124
|
95143
|
95144
|
95145
|
95146