Attachment 95138 Details for Bug 23768 – Bug 23768: Adjust the test for invalid ISBN

[patch] Bug 23768: Adjust the test for invalid ISBN

Bug-23768-Adjust-the-test-for-invalid-ISBN.patch (text/plain), 1.20 KB, created by Jonathan Druart on 2019-11-07 10:49:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-11-07 10:49:49 UTC

Size: 1.20 KB

patch

obsolete

>From d06d312cf1f3eedff7b1045485c2feec78f49df5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 7 Nov 2019 11:48:59 +0100
>Subject: [PATCH] Bug 23768: Adjust the test for invalid ISBN
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> t/Koha.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/Koha.t b/t/Koha.t
>index 9f794d4a8c..44c56f0e48 100755
>--- a/t/Koha.t
>+++ b/t/Koha.t
>@@ -91,7 +91,7 @@ ok($@ eq '', 'NormalizeISBN does not throw exception when converting to ISBN10 a
> ok(!defined $isbn, 'NormalizeISBN returns undef when converting to ISBN10 an ISBN starting with 979 (bug 13167)');
> 
> @isbns = GetVariationsOfISBNs('abc');
>-is(scalar(@isbns), 0, 'zero variations returned of invalid ISBN');
>+is(@isbns == 1 && $isbns[0] eq 'abc', 1, 'The unaltered version should be returned if invalid');
> 
> is( C4::Koha::GetNormalizedISBN('9780062059994 (hardcover bdg.) | 0062059998 (hardcover bdg.)'), '0062059998', 'Test GetNormalizedISBN' );
> is( C4::Koha::GetNormalizedISBN('9780385753067 (trade) | 0385753063 (trade) | 9780385753074 (lib. bdg.) | 0385753071 (lib. bdg.)'), '0385753063', 'Test GetNormalizedISBN' );
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23768: 93829 | 94963 | 95137 | 95138