Attachment 95139 Details for Bug 13749 – Bug 13749: On loading holds in patron account 'processing' is not translatable

[patch] Bug 13749: On loading holds in patron account 'processing' is not translatable

Bug-13749-On-loading-holds-in-patron-account-proce.patch (text/plain), 3.49 KB, created by Jonathan Druart on 2019-11-07 11:01:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-11-07 11:01:02 UTC

Size: 3.49 KB

patch

obsolete

>From 802133d1b4ace467e73b0162e7c818df0fcface9 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 8 Oct 2019 17:11:17 +0000
>Subject: [PATCH] Bug 13749: On loading holds in patron account 'processing' is
> not translatable
>
>This patch updates the DataTables configuration for two tables: The
>checkouts and holds lists shown on the checkout and patron details
>screen.
>
>The tables lacked the standard application of a custom set of
>defaults defined in js/datatables.js. It is in this file that custom
>language strings are defined for DataTable interface elements, pulling
>in the translated values from datatables.inc.
>
>Without our custom defaults applied, DataTables used its own defaults,
>which are not translated.
>
>To test, apply the patch and check out to a patron who has both
>checkouts and holds. The more the better to give you more time to
>observer the loading state of the tables.
>
> - Checkouts: This table doesn't exhibit any visible problems because
>   page-specific text is defined for the table's "Loading" message.
>   However, it still makes sense to apply the defaults to the table for
>   consistency's sake. There should be no visible changes to the table.
>
> - Holds: From the checkout or patron details page click the "Holds"
>   tab. While the table loads there should be a "Processing" message. If
>   you switch to another translation the message should appear in that
>   language.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 4 ++--
> koha-tmpl/intranet-tmpl/prog/js/holds.js     | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>index d07f8200cd..01be72b763 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>@@ -648,7 +648,7 @@ $(document).ready(function() {
>     var relativesIssuesTable;
>     $("#relatives-issues-tab").click( function() {
>         if ( ! relativesIssuesTable ) {
>-            relativesIssuesTable = $("#relatives-issues-table").dataTable({
>+            relativesIssuesTable = $("#relatives-issues-table").dataTable($.extend(true, {}, dataTablesDefaults, {
>                 "bAutoWidth": false,
>                 "sDom": "rt",
>                 "aaSorting": [],
>@@ -808,7 +808,7 @@ $(document).ready(function() {
>                         fnCallback(json)
>                     } );
>                 },
>-            });
>+            }));
>         }
>     });
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js
>index 14f1ab87ac..925b38b753 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js
>@@ -10,7 +10,7 @@ $(document).ready(function() {
>     function load_holds_table() {
>         var holds = new Array();
>         if ( ! holdsTable ) {
>-            holdsTable = $("#holds-table").dataTable({
>+            holdsTable = $("#holds-table").dataTable($.extend(true, {}, dataTablesDefaults, {
>                 "bAutoWidth": false,
>                 "sDom": "rt",
>                 "columns": [
>@@ -183,7 +183,7 @@ $(document).ready(function() {
>                         d.borrowernumber = borrowernumber;
>                     }
>                 },
>-            });
>+            }));
> 
>             $('#holds-table').on( 'draw.dt', function () {
>                 $(".hold-suspend").on( "click", function() {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 13749: 93889 | 94964 | 95139