Attachment 95159 Details for Bug 21301 – Bug 21301: Remove patron informations in reserves for GetRecords ILS-DI service

[patch] Bug 21301: Remove patron informations in reserves for GetRecords ILS-DI service

Bug-21301-Remove-patron-informations-in-reserves-f.patch (text/plain), 1.62 KB, created by Martin Renvoize (ashimema) on 2019-11-07 14:28:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-11-07 14:28:41 UTC

Size: 1.62 KB

patch

obsolete

>From 383cee4a15c66fb29d8816659b31995b2561596b Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Thu, 3 Oct 2019 15:43:56 +0200
>Subject: [PATCH] Bug 21301: Remove patron informations in reserves for
> GetRecords ILS-DI service
>
>Actually, the GetRecords service gives many information :
>borrowernumber (reserves field)
>
>The issue data should not be sent by these service, its a privacy problem.
>
>Test plan :
>1) Enable ILS-DI webservice
>2) Place hold on an item
>3) Go to {opac}/cgi-bin/koha/ilsdi.pl?service=GetRecords&id={biblionumber}
>4) Check the reserves tag content
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/ILSDI/Services.pm | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm
>index 9ee2043579..f419eaa0b3 100644
>--- a/C4/ILSDI/Services.pm
>+++ b/C4/ILSDI/Services.pm
>@@ -228,7 +228,6 @@ sub GetRecords {
> 
>         # Get most of the needed data
>         my $biblioitemnumber = $biblioitem->{'biblioitemnumber'};
>-        my $holds  = $biblio->current_holds->unblessed;
>         my $checkouts = Koha::Checkouts->search(
>             { biblionumber => $biblionumber },
>             {
>@@ -266,6 +265,12 @@ sub GetRecords {
>             push @{ $biblioitem->{items}->{item} }, \%item;
>         }
> 
>+        # Holds
>+        my $holds = $biblio->current_holds->unblessed;
>+        foreach my $hold (@$holds) {
>+            delete $hold->{'borrowernumber'};
>+        }
>+
>         # Hashref building...
>         $biblioitem->{'reserves'}->{'reserve'} = $holds;
>         $biblioitem->{'issues'}->{'issue'}     = $checkouts;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 21301: 93495 | 93603 | 95158 | 95159 | 95178 | 101818 | 109646 | 113061 | 113062 | 113063 | 113064 | 113065 | 113068 | 113069 | 113070 | 113071 | 113072 | 115022 | 115023 | 115024 | 115025 | 115026