Bugzilla – Attachment 95177 Details for
Bug 23986
Batch Record Deletion does not remove records from Elasticsearch search index
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23986: Pass strings to Catmandu for deletion
Bug-23986-Pass-strings-to-Catmandu-for-deletion.patch (text/plain), 1.49 KB, created by
Nick Clemens (kidclamp)
on 2019-11-08 03:00:46 UTC
(
hide
)
Description:
Bug 23986: Pass strings to Catmandu for deletion
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2019-11-08 03:00:46 UTC
Size:
1.49 KB
patch
obsolete
>From c807b825218ec3e5203f9d54764d76f55cace5db Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 7 Nov 2019 19:38:24 +0000 >Subject: [PATCH] Bug 23986: Pass strings to Catmandu for deletion > >The deletion subroutine expects to get a string, this is fine in most places, but when >we sort our records for batch deletion they are cast to numbers and the delete is not processed. > >This patch quotes the biblionumbers as strings before passing them to Catmandu > >To aid in detecting orphaned records you can use the patches on bug 22831 > >To test: > 1 - Have or create a bib > 2 - Go to Tools->Batch record deletion > 3 - Click 'Enter a list of record numbers' > 4 - Enter the biblionumber' > 5 - Confirm deletion > 6 - Search for the record, it still appears > 7 - Apply patch, restart all the things > 8 - Repeat 1-6 > 9 - This time the record is deleted >10 - Test other methods of record deletion to confirm the record is removed >--- > Koha/SearchEngine/Elasticsearch/Indexer.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/SearchEngine/Elasticsearch/Indexer.pm b/Koha/SearchEngine/Elasticsearch/Indexer.pm >index 3610f0191d..504ccc5856 100644 >--- a/Koha/SearchEngine/Elasticsearch/Indexer.pm >+++ b/Koha/SearchEngine/Elasticsearch/Indexer.pm >@@ -303,7 +303,7 @@ sub delete_index { > ) > ); > } >- $self->store->bag->delete($_) foreach @$biblionums; >+ $self->store->bag->delete("$_") foreach @$biblionums; > $self->store->bag->commit; > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23986
:
95171
|
95177
|
95188
|
95229