Attachment 95187 Details for Bug 23994 – Bug 23994: Fix random failure from AdditionalFields.t (U18)

[patch] Bug 23994: Fix random failure from AdditionalFields.t (U18)

Bug-23994-Fix-random-failure-from-AdditionalFields.patch (text/plain), 1.44 KB, created by Jonathan Druart on 2019-11-08 09:29:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-11-08 09:29:00 UTC

Size: 1.44 KB

patch

obsolete

>From e0c8b1df82bd77473216c594288c214db8ffb93a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 8 Nov 2019 10:28:01 +0100
>Subject: [PATCH] Bug 23994: Fix random failure from AdditionalFields.t (U18)
>
>t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t .. 1/12
> #   Failed test '->additional_field_values should return the correct values'
> #   at t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t line 82.
> #     Structures begin differing at:
> #          $got->[0]{value} = 'bar value for basket2'
> #     $expected->[0]{value} = 'foo value for basket2'
> # Looks like you failed 1 test of 12.
>
>We do not really know why, but the values are not returned in the order they are stored in DB. Fixing this random failure for now at test level.
>---
> t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t b/t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t
>index d0925cfa7b..e7e97c14f1 100755
>--- a/t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t
>+++ b/t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t
>@@ -65,7 +65,7 @@ is_deeply(
>                 record_id => $_->{record_id},
>                 value     => $_->{value},
>             }
>-        } @{ $additional_fields->unblessed }
>+        } sort{ $a->{id} <=> $b->{id} } @{ $additional_fields->unblessed }
>     ],
>     [
>         {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23994: 95187