Attachment 95189 Details for Bug 5365 – Bug 5365: Make more clear how to reopen a basket in a basket group

[patch] Bug 5365: Make more clear how to reopen a basket in a basket group

Bug-5365-Make-more-clear-how-to-reopen-a-basket-in.patch (text/plain), 2.41 KB, created by Marcel de Rooy on 2019-11-08 10:20:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2019-11-08 10:20:06 UTC

Size: 2.41 KB

patch

obsolete

>From 0bf39733efe78d3e91457b4054b16f282f23942d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 6 Nov 2019 10:45:56 +0100
>Subject: [PATCH] Bug 5365: Make more clear how to reopen a basket in a basket
> group
>Content-Type: text/plain; charset=utf-8
>
>The "reopen basket" button will be visible but disabled if the basket
>cannot be reopened. A tooltip is attached to the button to add more
>information.
>
>Note that the export button is still hidden, would it makes sense to
>display it (visible and active)?
>
>Test plan:
>- Create a basket
>- Close it
>- Go to the basket detail view
>=> The reopen button should be displayed and enabled
>
>- Attach it to a basket group
>- Go to the basket detail view
>=> The reopen button should be displayed but disabled
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>index 379b974eb7..8ce6f1658b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>@@ -145,15 +145,17 @@
>                 </div>
> 
>             [% ELSE %]
>-                [% UNLESS ( grouped ) %]
>                 <div id="toolbar" class="btn-toolbar">
>+                    [% IF grouped %]
>+                        <div title="Can not reopen baskets that are part of a basket group." class="btn-group">
>+                            <div class="btn-group"><a href="#" class="btn btn-default disabled" id="reopenbutton"><i class="fa fa-refresh"></i> Reopen this basket</a></div>
>+                        </div>
>+                    [% ELSE %]
>+                        <div class="btn-group"><a href="#" class="btn btn-default" id="reopenbutton"><i class="fa fa-refresh"></i> Reopen this basket</a></div>
> 
>-                    <div class="btn-group"><a href="#" class="btn btn-default" id="reopenbutton"><i class="fa fa-refresh"></i> Reopen this basket</a></div>
>-
>-                    [% PROCESS csv_export %]
>-
>+                        [% PROCESS csv_export %]
>+                    [% END %]
>                 </div>
>-                [% END %]
>             [% END %]
>             [% END %]
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 5365: 95092 | 95106 | 95189