Bugzilla – Attachment 95218 Details for
Bug 24002
Test suite is failing on MySQL 8
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24002: Incorrect DATE value: '00-00-0000' in C4/Serials.pm
Bug-24002-Incorrect-DATE-value-00-00-0000-in-C4Ser.patch (text/plain), 3.47 KB, created by
Jonathan Druart
on 2019-11-08 13:53:27 UTC
(
hide
)
Description:
Bug 24002: Incorrect DATE value: '00-00-0000' in C4/Serials.pm
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-11-08 13:53:27 UTC
Size:
3.47 KB
patch
obsolete
>From ca0b693429401edfbb59b80f26e049bd46d8dcb4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 8 Nov 2019 14:44:28 +0100 >Subject: [PATCH] Bug 24002: Incorrect DATE value: '00-00-0000' in > C4/Serials.pm > >t/db_dependent/Biblio.t .. 2/12 DBD::mysql::st execute failed: Incorrect DATE value: '00-00-0000' [for Statement " > SELECT serial.serialid, > serial.serialseq, > serial.planneddate, > serial.publisheddate, > serial.publisheddatetext, > serial.status, > serial.notes as notes, > year(IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate)) as year, > biblio.title as bibliotitle, > subscription.branchcode AS branchcode, > subscription.subscriptionid AS subscriptionid > FROM serial > LEFT JOIN subscription ON > (serial.subscriptionid=subscription.subscriptionid) > LEFT JOIN aqbooksellers on subscription.aqbooksellerid=aqbooksellers.id > LEFT JOIN biblio on biblio.biblionumber=subscription.biblionumber > WHERE subscription.biblionumber = ? > ORDER BY year DESC, > IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate) DESC, > serial.subscriptionid > " with ParamValues: 0='446'] at /kohadevbox/koha/C4/Serials.pm line 482. >--- > C4/Serials.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index dc0d841fdf..7d885132e4 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -304,7 +304,7 @@ sub GetFullSubscription { > serial.publisheddatetext, > serial.status, > serial.notes as notes, >- year(IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate)) as year, >+ year(IF(serial.publisheddate IS NULL,serial.publisheddate,serial.planneddate)) as year, > aqbooksellers.name as aqbooksellername, > biblio.title as bibliotitle, > subscription.branchcode AS branchcode, >@@ -316,7 +316,7 @@ sub GetFullSubscription { > LEFT JOIN biblio on biblio.biblionumber=subscription.biblionumber > WHERE serial.subscriptionid = ? > ORDER BY year DESC, >- IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate) DESC, >+ IF(serial.publisheddate IS NULL,serial.publisheddate,serial.planneddate) DESC, > serial.subscriptionid > |; > $debug and warn "GetFullSubscription query: $query"; >@@ -464,7 +464,7 @@ sub GetFullSubscriptionsFromBiblionumber { > serial.publisheddatetext, > serial.status, > serial.notes as notes, >- year(IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate)) as year, >+ year(IF(serial.publisheddate IS NULL,serial.publisheddate,serial.planneddate)) as year, > biblio.title as bibliotitle, > subscription.branchcode AS branchcode, > subscription.subscriptionid AS subscriptionid >@@ -475,7 +475,7 @@ sub GetFullSubscriptionsFromBiblionumber { > LEFT JOIN biblio on biblio.biblionumber=subscription.biblionumber > WHERE subscription.biblionumber = ? > ORDER BY year DESC, >- IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate) DESC, >+ IF(serial.publisheddate IS NULL,serial.publisheddate,serial.planneddate) DESC, > serial.subscriptionid > |; > my $sth = $dbh->prepare($query); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24002
:
95215
|
95216
|
95217
|
95218
|
95219
|
95220
|
95221
|
95222
|
95223
|
95224
|
95225
|
95226
|
95227
|
99118