Attachment 95276 Details for Bug 23893 – Bug 23893: Unit tests

[patch] Bug 23893: Unit tests

Bug-23893-Unit-tests.patch (text/plain), 4.42 KB, created by Tomás Cohen Arazi (tcohen) on 2019-11-11 19:15:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2019-11-11 19:15:23 UTC

Size: 4.42 KB

patch

obsolete

>From 620f99e0752e07d612d796860cfef9d7445cb6be Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 11 Nov 2019 15:03:29 -0300
>Subject: [PATCH] Bug 23893: Unit tests
>
>This patch introduces tests for the implemented methods.
>---
> t/db_dependent/Koha/Object.t | 124 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 122 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t
>index 7570b62afe..6d58588069 100755
>--- a/t/db_dependent/Koha/Object.t
>+++ b/t/db_dependent/Koha/Object.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 12;
>+use Test::More tests => 16;
> use Test::Exception;
> use Test::Warn;
> use DateTime;
>@@ -260,7 +260,127 @@ subtest "to_api() tests" => sub {
> 
>     # Pick a class that won't have a mapping for the API
>     my $illrequest = $builder->build_object({ class => 'Koha::Illrequests' });
>-    is_deeply( $illrequest->to_api, $illrequest->TO_JSON, 'If no to_api_method present, return TO_JSON' );
>+    is_deeply( $illrequest->to_api, $illrequest->TO_JSON, 'If no overloaded to_api_mapping method, return TO_JSON' );
>+
>+    $schema->storage->txn_rollback;
>+};
>+
>+subtest "to_api_mapping() tests" => sub {
>+
>+    plan tests => 1;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $illrequest = $builder->build_object({ class => 'Koha::Illrequests' });
>+    is_deeply( $illrequest->to_api_mapping, {}, 'If no to_api_mapping present, return empty hashref' );
>+
>+    $schema->storage->txn_rollback;
>+};
>+
>+subtest "from_api_mapping() tests" => sub {
>+
>+    plan tests => 3;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $city = $builder->build_object({ class => 'Koha::Cities' });
>+
>+    # Lets emulate an undef
>+    my $city_class = Test::MockModule->new('Koha::City');
>+    $city_class->mock( 'to_api_mapping',
>+        sub {
>+            return {
>+                cityid       => 'city_id',
>+                city_country => 'country',
>+                city_zipcode => undef
>+            };
>+        }
>+    );
>+
>+    is_deeply(
>+        $city->from_api_mapping,
>+        {
>+            city_id => 'cityid',
>+            country => 'city_country'
>+        },
>+        'Mapping returns correctly, undef ommited'
>+    );
>+
>+    $city_class->unmock( 'to_api_mapping');
>+    $city_class->mock( 'to_api_mapping',
>+        sub {
>+            return {
>+                cityid       => 'city_id',
>+                city_country => 'country',
>+                city_zipcode => 'postal_code'
>+            };
>+        }
>+    );
>+
>+    is_deeply(
>+        $city->from_api_mapping,
>+        {
>+            city_id => 'cityid',
>+            country => 'city_country'
>+        },
>+        'Reverse mapping is cached'
>+    );
>+
>+    # Get a fresh object
>+    $city = $builder->build_object({ class => 'Koha::Cities' });
>+    is_deeply(
>+        $city->from_api_mapping,
>+        {
>+            city_id     => 'cityid',
>+            country     => 'city_country',
>+            postal_code => 'city_zipcode'
>+        },
>+        'Fresh mapping loaded'
>+    );
>+
>+    $schema->storage->txn_rollback;
>+};
>+
>+subtest 'set_from_api() tests' => sub {
>+
>+    plan tests => 4;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $city = $builder->build_object({ class => 'Koha::Cities' });
>+    my $city_unblessed = $city->unblessed;
>+    my $attrs = {
>+        name        => 'Cordoba',
>+        country     => 'Argentina',
>+        postal_code => '5000'
>+    };
>+    $city->set_from_api($attrs);
>+
>+    is( $city->city_state, $city_unblessed->{city_state}, 'Untouched attributes are preserved' );
>+    is( $city->city_name, $attrs->{name}, 'city_name updated correctly' );
>+    is( $city->city_country, $attrs->{country}, 'city_country updated correctly' );
>+    is( $city->city_zipcode, $attrs->{postal_code}, 'city_zipcode updated correctly' );
>+
>+    $schema->storage->txn_rollback;
>+};
>+
>+subtest 'new_from_api() tests' => sub {
>+
>+    plan tests => 4;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $attrs = {
>+        name        => 'Cordoba',
>+        country     => 'Argentina',
>+        postal_code => '5000'
>+    };
>+    my $city = Koha::City->new_from_api($attrs);
>+
>+    is( ref($city), 'Koha::City', 'Object type is correct' );
>+    is( $city->city_name,    $attrs->{name}, 'city_name updated correctly' );
>+    is( $city->city_country, $attrs->{country}, 'city_country updated correctly' );
>+    is( $city->city_zipcode, $attrs->{postal_code}, 'city_zipcode updated correctly' );
> 
>     $schema->storage->txn_rollback;
> };
>-- 
>2.24.0

Actions: View | Diff | Splinter Review

Attachments on bug 23893: 95276 | 95277 | 95278 | 95311 | 95312 | 95313 | 95314 | 95315 | 96126 | 96127 | 96128 | 96129 | 96130 | 96652 | 96655 | 96656 | 96657 | 96658 | 96659 | 96660 | 96661 | 96662 | 96665 | 96666 | 96920 | 96921 | 96922 | 96923 | 96924 | 96925 | 96926 | 96927 | 96928 | 96929 | 96930 | 96931 | 96932 | 96933 | 96934 | 96935 | 96936 | 96937 | 97391