Attachment 95327 Details for Bug 23822 – Bug 23822: Fix deletion of patrons with credit

[patch] Bug 23822: Fix deletion of patrons with credit

Bug-23822-Fix-deletion-of-patrons-with-credit.patch (text/plain), 1.41 KB, created by Martin Renvoize (ashimema) on 2019-11-12 14:46:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-11-12 14:46:40 UTC

Size: 1.41 KB

patch

obsolete

>From 1062698280e25484c31e0c3be406e25c82e2ebc6 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 11 Nov 2019 12:35:30 +0100
>Subject: [PATCH] Bug 23822: Fix deletion of patrons with credit
>
>There are bugs in both master and 19.05, but different.
>
>Anyway we should have this check to make sure a negative value will have
>the same behavior: trigger the confirmation message (instead of a blank
>page).
>
>If we want to reject the deletion of a patron with credit we should
>handle it on a separate bug report (behavior change)
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> members/deletemem.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/members/deletemem.pl b/members/deletemem.pl
>index b30d28d5f6..5434cdfe53 100755
>--- a/members/deletemem.pl
>+++ b/members/deletemem.pl
>@@ -104,7 +104,7 @@ if ( $op eq 'delete_confirm' or $countissues > 0 or $charges or $is_guarantor )
>         $template->param(ItemsOnHold => $countholds);
>     }
>     # This is silly written but reflect the same conditions as above
>-    if ( not $countissues > 0 and not $charges and not $is_guarantor ) {
>+    if ( not $countissues > 0 and not $charges > 0 and not $is_guarantor ) {
>         $template->param(
>             op         => 'delete_confirm',
>             csrf_token => Koha::Token->new->generate_csrf({ session_id => scalar $input->cookie('CGISESSID') }),
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23822: 95254 | 95327 | 95388