Attachment 95363 Details for Bug 24022 – Bug 24022: Remove unecessary delete from authorised_values

[patch] Bug 24022: Remove unecessary delete from authorised_values

Bug-24022-Remove-unecessary-delete-from-authorised.patch (text/plain), 1.02 KB, created by Nick Clemens (kidclamp) on 2019-11-13 11:30:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-11-13 11:30:40 UTC

Size: 1.02 KB

patch

obsolete

>From 464943bfe05d2047ce306b8c7cb77596392048df Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 12 Nov 2019 17:16:44 +0100
>Subject: [PATCH] Bug 24022: Remove unecessary delete from authorised_values
>
>Why do we need that exactly?
>The cache is not flushed so it should not be needed.
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> t/db_dependent/Koha/Z3950Responder/Session.t | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Z3950Responder/Session.t b/t/db_dependent/Koha/Z3950Responder/Session.t
>index 59930810e9..33bfd4f527 100644
>--- a/t/db_dependent/Koha/Z3950Responder/Session.t
>+++ b/t/db_dependent/Koha/Z3950Responder/Session.t
>@@ -19,9 +19,6 @@ subtest 'add_item_status' => sub {
> 
>     plan tests => 2;
> 
>-    # Make sure we are using default values set in code
>-    $builder->schema->resultset( 'AuthorisedValue' )->delete_all;
>-
>     ## FIRST ITEM HAS ALL THE STATUSES ##
>     my $item_1 = $builder->build({
>         source => 'Item',
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24022: 95332 | 95333 | 95336 | 95362 | 95363 | 95364