Attachment 95387 Details for Bug 24026 – Bug 24026: (bug 22847 follow-up) Display correctly max[onsite]issueqty (not the propagated ones)

[patch] Bug 24026: (bug 22847 follow-up) Display correctly max[onsite]issueqty (not the propagated ones)

Bug-24026-bug-22847-follow-up-Display-correctly-ma.patch (text/plain), 2.22 KB, created by Martin Renvoize (ashimema) on 2019-11-13 13:50:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-11-13 13:50:24 UTC

Size: 2.22 KB

patch

obsolete

>From c4ca7bff689a37debc7aa850fdd42bfc5a19386e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 13 Nov 2019 12:35:45 +0100
>Subject: [PATCH] Bug 24026: (bug 22847 follow-up) Display correctly
> max[onsite]issueqty (not the propagated ones)
>
>See bug 22847. We should never call ->Get in this template, we want
>to display the values in the DB, not the calculated ones
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index ed8bc3034e..79b002c00a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -137,7 +137,7 @@
>                                                             [% ELSE %]&nbsp;[% END %]
>                                                         </td>
>                             <td>
>-                                [% SET rule_value = CirculationRules.Get( rule.branchcode, rule.categorycode, rule.itemtype, 'maxissueqty' ) %]
>+                                [% SET rule_value = CirculationRules.Search( rule.branchcode, rule.categorycode, rule.itemtype, 'maxissueqty' ) %]
>                                 [% IF rule_value || rule_value == "0"  %]
>                                     [% rule_value | html %]
>                                 [% ELSE %]
>@@ -145,7 +145,7 @@
>                                 [% END %]
>                             </td>
>                             <td>
>-                                [% SET rule_value = CirculationRules.Get( rule.branchcode, rule.categorycode, rule.itemtype, 'maxonsiteissueqty' ) %]
>+                                [% SET rule_value = CirculationRules.Search( rule.branchcode, rule.categorycode, rule.itemtype, 'maxonsiteissueqty' ) %]
>                                 [% IF rule_value || rule_value == "0" %]
>                                     [% rule_value | html %]
>                                 [% ELSE %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24026: 95365 | 95366 | 95369 | 95370 | 95373 | 95386 | 95387