Bugzilla – Attachment 95470 Details for
Bug 23838
Add ability to view item renew history
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23838: (follow-up) Rephrase log message
Bug-23838-follow-up-Rephrase-log-message.patch (text/plain), 1.99 KB, created by
Bouzid Fergani
on 2019-11-15 20:50:02 UTC
(
hide
)
Description:
Bug 23838: (follow-up) Rephrase log message
Filename:
MIME Type:
Creator:
Bouzid Fergani
Created:
2019-11-15 20:50:02 UTC
Size:
1.99 KB
patch
obsolete
>From 0f50c1acf9298f4d9d21d51fb5d0351f9832dea4 Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Thu, 24 Oct 2019 15:11:22 +0100 >Subject: [PATCH] Bug 23838: (follow-up) Rephrase log message > >As suggested by Owen in comment #10 > >Thanks Owen, I went for the second option > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> >--- > .../intranet-tmpl/prog/en/includes/patron-renewal-modal-strings.inc | 3 +-- > koha-tmpl/intranet-tmpl/prog/js/patron-renewal-modal.js | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-renewal-modal-strings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-renewal-modal-strings.inc >index f072718..dde6014 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-renewal-modal-strings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-renewal-modal-strings.inc >@@ -1,5 +1,4 @@ > <script> > var renewed_prop = _("Note: %s out of %s renewals have been logged"); >- var renewed_on = _("Renewed"); >- var by = _("by"); >+ var renewed = _("Renewed by"); > </script> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/patron-renewal-modal.js b/koha-tmpl/intranet-tmpl/prog/js/patron-renewal-modal.js >index 4323190..0080e55 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/patron-renewal-modal.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/patron-renewal-modal.js >@@ -21,6 +21,6 @@ $(document).ready(function(){ > }); > }); > function createLi(renewal) { >- return '<li>' + renewed_on + ' <span style="font-weight:bold">' + renewal.timestamp + '</span> ' + by + ' <span style="font-weight:bold">' + renewal.renewed_by.firstname + ' ' + renewal.renewed_by.surname + '</li>'; >+ return '<li><span style="font-weight:bold">' + renewal.timestamp + '</span> ' + renewed + ' <span style="font-weight:bold">' + renewal.renewed_by.firstname + ' ' + renewal.renewed_by.surname + '</li>'; > } > }); >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23838
:
94394
|
94395
|
94635
|
94636
|
94663
|
94664
|
94676
|
94681
|
94682
|
94683
|
94684
|
94685
|
95466
|
95467
|
95468
|
95469
|
95470
|
95471
|
95472
|
96186
|
96187
|
96188
|
96189
|
96190
|
131892
|
131914
|
131915
|
133945
|
133946
|
133966
|
133967
|
133968
|
134890
|
134891
|
134892
|
137167
|
137168
|
137169
|
138007
|
138019
|
138020
|
138021
|
138022
|
138039
|
138040
|
138041
|
138042
|
138043