Attachment 95505 Details for Bug 23916 – Bug 23916: Add "RecordIssuer" syspref

[patch] Bug 23916: Add "RecordIssuer" syspref

Bug-23916-Add-RecordIssuer-syspref.patch (text/plain), 3.42 KB, created by Andrew Isherwood on 2019-11-18 13:48:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2019-11-18 13:48:09 UTC

Size: 3.42 KB

patch

obsolete

>From 71917e572adcae85105d011379f9becc2153af20 Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Thu, 31 Oct 2019 10:22:24 +0000
>Subject: [PATCH] Bug 23916: Add "RecordIssuer" syspref
>
>This patch adds the "RecordIssuer" syspref, which is disabled by default
>
>Signed-off-by: Ben Veasey <B.T.Veasey@lboro.ac.uk>
>---
> .../mysql/atomicupdate/bug_23916_add_RecordIssuer_syspref.perl    | 8 ++++++++
> installer/data/mysql/sysprefs.sql                                 | 1 +
> .../prog/en/modules/admin/preferences/circulation.pref            | 7 +++++++
> 3 files changed, 16 insertions(+)
> create mode 100644 installer/data/mysql/atomicupdate/bug_23916_add_RecordIssuer_syspref.perl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_23916_add_RecordIssuer_syspref.perl b/installer/data/mysql/atomicupdate/bug_23916_add_RecordIssuer_syspref.perl
>new file mode 100644
>index 0000000000..ad3dca7b18
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_23916_add_RecordIssuer_syspref.perl
>@@ -0,0 +1,8 @@
>+$DBversion = 'XXX'; # will be replaced by the RM
>+if( CheckVersion( $DBversion ) ) {
>+
>+    $dbh->do( q| INSERT IGNORE INTO systempreferences (variable, value, explanation, options, type) VALUES ('RecordIssuer', '0', 'If enabled, when an item is issued, the user who issued the item is recorded', '', 'YesNo'); | );
>+
>+    SetVersion( $DBversion );
>+    print "Upgrade to $DBversion done (Bug 23916 - Add RecordIssuer syspref)\n";
>+}
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index 9fc3d5821e..cffd9d7b22 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -511,6 +511,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('QueryWeightFields','1',NULL,'If ON, enables field weighting','YesNo'),
> ('QuoteOfTheDay','0',NULL,'Enable or disable display of Quote of the Day on the OPAC home page','YesNo'),
> ('RandomizeHoldsQueueWeight','0',NULL,'if ON, the holds queue in circulation will be randomized, either based on all location codes, or by the location codes specified in StaticHoldsQueueWeight','YesNo'),
>+('RecordIssuer','0',NULL,'If ON, when an item is issued, the user who issued the item is recorded','YesNo'),
> ('RecordLocalUseOnReturn','0',NULL,'If ON, statistically record returns of unissued items as local use, instead of return','YesNo'),
> ('RefundLostOnReturnControl','CheckinLibrary','CheckinLibrary|ItemHomeBranch|ItemHoldingBranch','If a lost item is returned, choose which branch to pick rules for refunding.','Choice'),
> ('RenewalLog','0','','If ON, log information about renewals','YesNo'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index e949eac982..321d85dbbe 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -422,6 +422,13 @@ Circulation:
>                   nothing : "do nothing"
>             - .
>         -
>+            - "When issuing an item, "
>+            - pref: RecordIssuer
>+              choices:
>+                  yes: "record"
>+                  no: "don't record"
>+            - "the user who issued the item."
>+        -
>             - "Mark items as returned when flagged as lost "
>             - pref: MarkLostItemsAsReturned
>               multiple:
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23916: 94914 | 94915 | 94916 | 94917 | 94918 | 95503 | 95504 | 95505 | 95506 | 95507 | 95508 | 95509 | 97719 | 97720 | 97721 | 97722 | 97723 | 97724 | 98586 | 98587 | 98588 | 98589 | 98590 | 98591 | 98594 | 99886 | 99887 | 99888 | 99889 | 99890 | 99891 | 110649 | 110650 | 110651 | 110652 | 110653 | 110654 | 110655 | 111485 | 111486 | 111487 | 111488 | 111489 | 111490 | 111491 | 111492 | 111966 | 111967 | 111968 | 111969 | 111970 | 111971 | 111972 | 111973 | 111974 | 112248 | 112249 | 112250 | 112251 | 112252 | 112253 | 112254 | 112255 | 112256 | 112257 | 112363 | 112364 | 112365 | 112366 | 112367 | 112368 | 112369 | 112370 | 112371 | 112372 | 112373 | 113035 | 113036 | 113037 | 113038 | 113039 | 113040 | 113041 | 113042 | 113043 | 113044 | 113045 | 113316 | 113317 | 113318 | 113319 | 113320 | 113321 | 113322 | 113323 | 113324 | 113325 | 113326 | 113327 | 113367 | 113368 | 113369 | 113370 | 113371 | 113372 | 113373 | 113374 | 113375 | 113376 | 113377 | 113378 | 113379 | 113380 | 113381 | 113382 | 113396