Bugzilla – Attachment 95517 Details for
Bug 14973
Add an alert during purchase suggestion submissions to warn the user when an existing biblio appears to satisfy the request
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14973: Fix edit a suggestion and dup found
Bug-14973-Fix-edit-a-suggestion-and-dup-found.patch (text/plain), 1.56 KB, created by
Jonathan Druart
on 2019-11-18 17:00:57 UTC
(
hide
)
Description:
Bug 14973: Fix edit a suggestion and dup found
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-11-18 17:00:57 UTC
Size:
1.56 KB
patch
obsolete
>From 8c2cf9c3b081ccb67a626f2821102c7aeb173709 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 18 Nov 2019 16:53:41 +0100 >Subject: [PATCH] Bug 14973: Fix edit a suggestion and dup found > >The find duplicate call must only be done when the suggestion is new. It >does not make sense to search for a duplicate when the suggestion >already exists. > >This patch also fixes a side-effect: >- Create a suggestion using an existing biblio title >- Ignore the warning and save >- Edit again and save >=> BOOM on date > >Template process failed: undef error - The given date (18/11/2019) does >not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm >line 168 > >The dates are not processed and so badly formatted when sent to the >template. >--- > suggestion/suggestion.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index 60dc7ffdf0..3bf52ab6f3 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -133,7 +133,7 @@ if ( $op =~ /save/i ) { > itemtype => $suggestion_only->{itemtype}, > }); > >- if ( ( my ($duplicatebiblionumber, $duplicatetitle) = FindDuplicate($biblio) ) && !$save_confirmed ) { >+ if ( !$suggestion_only->{suggestionid} && ( my ($duplicatebiblionumber, $duplicatetitle) = FindDuplicate($biblio) ) && !$save_confirmed ) { > push @messages, { type => 'error', code => 'biblio_exists', id => $duplicatebiblionumber, title => $duplicatetitle }; > $template->param( > messages => \@messages, >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14973
:
43193
|
44091
|
44319
|
44320
|
44334
|
44335
|
60877
|
60913
|
93141
|
93142
|
94297
|
94298
|
94301
|
94302
|
94303
|
94304
|
95113
|
95114
|
95517
|
96255
|
96256
|
96257
|
96258
|
96259
|
96260
|
96261
|
96325
|
96326
|
96327
|
96328
|
96329
|
96330
|
96331