Bugzilla – Attachment 95544 Details for
Bug 23964
An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23964: (follow-up) more test clarification
Bug-23964-follow-up-more-test-clarification.patch (text/plain), 3.29 KB, created by
Nick Clemens (kidclamp)
on 2019-11-19 11:58:17 UTC
(
hide
)
Description:
Bug 23964: (follow-up) more test clarification
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2019-11-19 11:58:17 UTC
Size:
3.29 KB
patch
obsolete
>From ba1d94da25de8b50eecb1da2ad2b6b34ec00d54b Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 19 Nov 2019 11:57:52 +0000 >Subject: [PATCH] Bug 23964: (follow-up) more test clarification > >--- > .../prog/en/modules/members/tables/guarantor_search.tt | 2 +- > t/db_dependent/Reserves.t | 6 ++++-- > 2 files changed, 5 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/guarantor_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/guarantor_search.tt >index a82f0e8dcb..633765ddaa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/guarantor_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/guarantor_search.tt >@@ -18,7 +18,7 @@ > "dt_address": > "[% INCLUDE escape_address data=data %]", > "dt_action": >- "<a href=\"#\" class=\"btn btn-default btn-xs select_user\" data-borrowernumber=\"[% data.borrowernumber | html %]\">Select</a><input type=\"hidden\" id=\"borrower_data[% data.borrowernumber | html %]\" name=\"borrower_data[% data.borrowernumber | html %]\" value=\"[% To.json(data) | html %]\" />" >+ "<a href=\"#\" class=\"btn btn-default btn-xs select_user\" data-borrowernumber=\"[% data.borrowernumber | html %]\">Select</a><input type=\"hidden\" id=\"borrower_data[% data.borrowernumber | html %]\" name=\"borrower_data[% data.borrowernumber | html %]\" value=\"[% data | html | $To %]\" />" > }[% UNLESS loop.last %],[% END %] > [% END %] > ] >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index 92c9068738..84fefb7cbc 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -672,7 +672,7 @@ subtest '_koha_notify_reserve() tests' => sub { > }; > > subtest 'ReservesNeedReturns' => sub { >- plan tests => 10; >+ plan tests => 11; > > my $library = $builder->build_object( { class => 'Koha::Libraries' } ); > my $item_info = { >@@ -721,8 +721,10 @@ subtest 'ReservesNeedReturns' => sub { > $hold = place_item_hold( $patron, $item, $library, $priority ); > is( $hold->priority, 0, 'If ReservesNeedReturns is 0 and damaged holds allowed, priority must have been set to 0' ); > is( $hold->found, 'W', 'If ReservesNeedReturns is 0 and damaged holds allowed, found must have been set waiting' ); >+ $hold->delete; > > my $hold_1 = place_item_hold( $patron, $item, $library, $priority ); >+ is( $hold_1->priority, 0, 'First hold on item is set to waiting with ReservesNeedReturns set to 0' ); > $hold = place_item_hold( $patron_2, $item, $library, $priority ); > is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item already on hold priority must be set to 1' ); > $hold->delete; >@@ -734,7 +736,7 @@ subtest 'ReservesNeedReturns' => sub { > } }); > $item->damaged(0)->store; > $hold = place_item_hold( $patron, $item, $library, $priority ); >- isnt( $hold->priority, 0, 'If ReservesNeedReturns is 0 but item in transit the hold must not be set to waiting' ); >+ is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item in transit the hold must not be set to waiting' ); > > t::lib::Mocks::mock_preference('ReservesNeedReturns', 1); # Don't affect other tests > }; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23964
:
95016
|
95017
|
95021
|
95022
|
95111
|
95249
|
95544
|
95594
|
95595
|
95596
|
95597
|
95598
|
95599
|
95639
|
95640
|
95641
|
95642
|
95643
|
95644
|
95780
|
95781