Attachment 95572 Details for Bug 23676 – Bug 23676: Use 'false' for opac suppression

[patch] Bug 23676: Use 'false' for opac suppression

Bug-23676-Use-false-for-opac-suppression.patch (text/plain), 1.49 KB, created by Nick Clemens (kidclamp) on 2019-11-19 15:50:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-11-19 15:50:58 UTC

Size: 1.49 KB

patch

obsolete

>From ab5a6d32f0253812926d853d4b022147862413cc Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 25 Sep 2019 19:04:13 +0000
>Subject: [PATCH] Bug 23676: Use 'false' for opac suppression
>
>To test:
> 1 - Enable ES
> 2 - Enable OpacSuppression
> 3 - Suppress a bib in staff client
>     Edit 942n to be 1
> 4 - Search the opac for anything
> 5 - Tail the plack logs and note a deprecation warning
> 6 - Apply patch
> 7 - Restart all the things
> 8 - Repeat search on opac
> 9 - No error/warn in logs
>10 - Record is correctly suppressed
>---
> Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>index 4a7cede380..1aeffd12b3 100644
>--- a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>+++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>@@ -177,7 +177,7 @@ sub build_query_compat {
>         my @sort_params  = $self->_convert_sort_fields(@$sort_by);
>         my @index_params = $self->_convert_index_fields(@$indexes);
>         my $limits       = $self->_fix_limit_special_cases($orig_limits);
>-        if ( $params->{suppress} ) { push @$limits, "suppress:0"; }
>+        if ( $params->{suppress} ) { push @$limits, "suppress:false"; }
>         # Merge the indexes in with the search terms and the operands so that
>         # each search thing is a handy unit.
>         unshift @$operators, undef;    # The first one can't have an op
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23676: 93161 | 95572 | 96695 | 97220