Bugzilla – Attachment 95593 Details for
Bug 23982
Count/pagination broken for reports with duplicated column names
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23982: Fix the failing test
Bug-23982-Fix-the-failing-test.patch (text/plain), 904 bytes, created by
Jonathan Druart
on 2019-11-20 08:50:21 UTC
(
hide
)
Description:
Bug 23982: Fix the failing test
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-11-20 08:50:21 UTC
Size:
904 bytes
patch
obsolete
>From 04a3863be60d3ad0ad9638d189ffa5b38df9373c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 20 Nov 2019 09:49:23 +0100 >Subject: [PATCH] Bug 23982: Fix the failing test > > # Failed test 'nb_rows returns 0 on bad queries' > # at t/db_dependent/Reports/Guided.t line 441. > # got: undef > # expected: '0' > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Reports/Guided.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm >index 341c78bd91..e20c99b8fc 100644 >--- a/C4/Reports/Guided.pm >+++ b/C4/Reports/Guided.pm >@@ -427,7 +427,8 @@ sub nb_rows { > > > my $dbh = C4::Context->dbh; >- my ( $sth, $n ); >+ my $sth; >+ my $n = 0; > > my $RaiseError = $dbh->{RaiseError}; > my $PrintError = $dbh->{PrintError}; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23982
:
95479
|
95545
|
95548
| 95593