Bugzilla – Attachment 95617 Details for
Bug 24072
Typos in advance_notices.pl causes DUEDGST not to be sent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24072 - Typos in advance_notices.pl causes DUEDGST not to be sent
Bug-24072---Typos-in-advancenoticespl-causes-DUEDG.patch (text/plain), 1.95 KB, created by
Magnus Enger
on 2019-11-20 14:26:12 UTC
(
hide
)
Description:
Bug 24072 - Typos in advance_notices.pl causes DUEDGST not to be sent
Filename:
MIME Type:
Creator:
Magnus Enger
Created:
2019-11-20 14:26:12 UTC
Size:
1.95 KB
patch
obsolete
>From 58903cfa367b02e082f65c664e22c8740d78be4c Mon Sep 17 00:00:00 2001 >From: Magnus Enger <magnus@libriotech.no> >Date: Wed, 20 Nov 2019 15:15:15 +0100 >Subject: [PATCH] Bug 24072 - Typos in advance_notices.pl causes DUEDGST not to > be sent > >There are two typos in advance_notics.pl that cause DUEDGST messages >not to be sent. See Bugzilla for full details. > >If you think the typo is sufficiently obvious, you can just eyeball the >patch and sign off, methinks. Otherwise, testing can be done something >like this: >- Make sure you have enabled enhanced messaging preferences, and a > patron with "Email" and "Digests only" set for "Item due" messages >- Issue an item to this patron, with due date today >- Run something like this to generate advance notices: > $ sudo koha-shell -c "perl \ > /home/vagrant/kohaclone/misc/cronjobs/advance_notices.pl -n -c" kohadev >- See that no notices are shown (-n means messages will go to stdout, > instead of into the message queue). >- Apply the patch and run advance_notices.pl again, as before. A DUEDGST > message should now be displayed. >--- > misc/cronjobs/advance_notices.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl >index d98783123d..af97c4103b 100755 >--- a/misc/cronjobs/advance_notices.pl >+++ b/misc/cronjobs/advance_notices.pl >@@ -390,7 +390,7 @@ if ($digest_per_branch) { > while (my ($branchcode, $digests) = each %$due_digest) { > send_digests({ > sth => $sth_digest, >- digest => $due_digest, >+ digests => $due_digest, > letter_code => 'DUEDGST', > branchcode => $branchcode, > get_item_info => sub { >@@ -419,7 +419,7 @@ if ($digest_per_branch) { > > send_digests({ > sth => $sth_digest, >- digest => $due_digest, >+ digests => $due_digest, > letter_code => 'DUEDGST', > get_item_info => sub { > my $params = shift; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24072
:
95617
|
95697
|
95754