Attachment 95637 Details for Bug 20948 – Bug 20948: Only display item-level hold info if first hold

[patch] Bug 20948: Only display item-level hold info if first hold

Bug-20948-Only-display-item-level-hold-info-if-fir.patch (text/plain), 2.66 KB, created by ByWater Sandboxes on 2019-11-20 23:15:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2019-11-20 23:15:13 UTC

Size: 2.66 KB

patch

obsolete

>From f102e56cf6fef90435a0b57e446dd6a8a2c7abdb Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 18 Nov 2019 10:30:04 +0100
>Subject: [PATCH] Bug 20948: Only display item-level hold info if first hold
>
>On the item list of the catalogue detail page we display next item-level
>hold info even if it is not the next hold. That leads to confusion as it
>will not necessarily be the accurate info.
>
>This patch makes the following changes:
>- Display the item-level hold only if it is the next hold (priority ==
>1)
>- Display "There is an item level hold on this item (priority=X)"
>if there is at least 1 item-level hold placed on this item
>
>Test plan:
>- Place several next available holds on a single item record
>- Place an item level hold on the item
>- Go the the biblio detail page
>=> Without this patch, the item will show the item level hold
>=> With the patch you see "There is an item level hold on this item"
>- Check the item in, confirm the hold
>=> No changes, the item will show the waiting hold info
>- Cancel all the holds except the item-level one
>=> No changes, the item will how the item-level one
>
>Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 615d09eaef..e6cb2e93bc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -359,10 +359,12 @@
>                         [% IF hold %]
>                             [% IF hold.waitingdate %]
>                                 Waiting at [% Branches.GetName( hold.branchcode ) | html %] since [% hold.waitingdate | $KohaDates %].
>-                            [% ELSE %]
>+                            [% ELSIF hold.priority == 1 %]
>                                 Item-level hold (placed [% hold.reservedate | $KohaDates %]) for delivery at [% Branches.GetName( hold.branchcode ) | html %].
>+                            [% ELSE %]
>+                                There is an item level hold on this item (priority = [% hold.priority %]).
>                             [% END %]
>-                            [% IF ( canreservefromotherbranches ) %]
>+                            [% IF canreservefromotherbranches AND ( hold.waitingdate OR hold.priority == 1 ) %]
>                                 Hold for:
>                                 [% INCLUDE 'patron-title.inc' patron=hold.borrower hide_patron_infos_if_needed=1 %]
>                             [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20948: 76145 | 76216 | 95476 | 95477 | 95636 | 95637 | 95870 | 95871 | 96137