Attachment 95647 Details for Bug 23184 – Bug 23184: Don't select branches for export by default

[patch] Bug 23184: Don't select branches for export by default

Bug-23184-Dont-select-branches-for-export-by-defau.patch (text/plain), 2.63 KB, created by Marcel de Rooy on 2019-11-21 07:51:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2019-11-21 07:51:53 UTC

Size: 2.63 KB

patch

obsolete

>From 4f58c3bc94a61f768b683c5e496fc008c6b688e4 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 4 Nov 2019 12:45:16 +0000
>Subject: [PATCH] Bug 23184: Don't select branches for export by default
>Content-Type: text/plain; charset=utf-8
>
>This patch changes the include to require passing "selectall=1" to select all items
>
>This include is only used in this page, so changes should not have side effects
>git grep "branch-selector\.inc"
>
>This patch also corrects a mismatch in the class names
>
>To test:
>1 - Browse to Tools->Export data
>2 - Note all branches are selected
>3 - Note this will exclude records wiuthout items if you click 'Export bibiographic records'
>4 - Apply patch
>5 - Visit page again
>6 - Note no branches are selected by default
>7 - Confirm 'Select all/Clear all' still work
>8 - Note record with no items are exported by default now
>
>Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc
>index f05fa91f6a..35421e930e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc
>@@ -1,10 +1,4 @@
>-[%# First check to see if we have anything selected, otherwise we select all %]
>-[% selectall = 1 %]
>-[% FOREACH branch IN branches %]
>-    [% IF branch.selected %]
>-        [% selectall = 0 %]
>-    [% END %]
>-[% END %]
>+[%# To select all include with selectall = 1 %]
> <div class="branchselector">
>     <p><a href="#" id="checkall"> <i class="fa fa-check"></i> Select all</a> | <a href="#" id="checknone"> <i class="fa fa-remove"></i> Clear all</a></p>
>     <div class="branchgridrow">
>@@ -13,7 +7,7 @@
>             [% IF branch.selected || (selectall == 1) %]
>                 <input id="branch_[% branch.branchcode | html %]" class="branch_select" type="checkbox" name="branch" value="[% branch.branchcode | html %]" checked="checked" />
>             [% ELSE %]
>-                <input id="branch_[% branch.branchcode | html %]" class="branch-select" type="checkbox" name="branch" value="[% branch.branchcode | html %]" />
>+                <input id="branch_[% branch.branchcode | html %]" class="branch_select" type="checkbox" name="branch" value="[% branch.branchcode | html %]" />
>             [% END %]
> 
>             <label for="branch_[% branch.branchcode | html %]">[% branch.branchname | html %]</label>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23184: 95002 | 95590 | 95647