Attachment 95649 Details for Bug 23721 – Bug 23721: Use basketgroup's name to name the CSV export file

[patch] Bug 23721: Use basketgroup's name to name the CSV export file

Bug-23721-Use-basketgroups-name-to-name-the-CSV-ex.patch (text/plain), 1.54 KB, created by Marcel de Rooy on 2019-11-21 08:31:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2019-11-21 08:31:55 UTC

Size: 1.54 KB

patch

obsolete

>From 4a6af14535ab5f612efb0efa8e21533c89fa1c21 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 19 Nov 2019 11:12:32 +0100
>Subject: [PATCH] Bug 23721: Use basketgroup's name to name the CSV export file
>MIME-Version: 1.0
>Content-Type: text/plain; charset=utf-8
>Content-Transfer-Encoding: 8bit
>Content-Type: text/plain; charset=utf-8
>
>When exporting a basket group, the names of the files are different:
> * pdf => aqbasketgroup.name(.pdf)
> * csv => aqbasketgroup.id(.csv)
>
>Better to use basketgroup's name for consistency and readability
>
>Test plan:
>Create a basketgroup and export it in pdf and CSV. The name of the
>generated file must be the basketgroup's name suffixed by the extension.
>
>Signed-off-by: SÃ©verine QUEUNE <severine.queune@bulac.fr>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> acqui/basketgroup.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl
>index cc3f9fcc48..ffa4ffb2aa 100755
>--- a/acqui/basketgroup.pl
>+++ b/acqui/basketgroup.pl
>@@ -330,9 +330,10 @@ if ( $op eq "add" ) {
> # export a closed basketgroup in csv
> #
>     my $basketgroupid = $input->param('basketgroupid');
>+    my $basketgroup = GetBasketgroup($basketgroupid);
>     print $input->header(
>         -type       => 'text/csv',
>-        -attachment => 'basketgroup' . $basketgroupid . '.csv',
>+        -attachment => ( $basketgroup->{name} || $basketgroupid ) . '.csv'
>     );
>     print GetBasketGroupAsCSV( $basketgroupid, $input );
>     exit;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23721: 95531 | 95540 | 95649