Bugzilla – Attachment 95801 Details for
Bug 23246
Record detail page jumps into the 'images' tab if no holdings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23246: Only jump into the 'images' tab HTML5MediaEnabled is set to
Bug-23246-Only-jump-into-the-images-tab-HTML5Media.patch (text/plain), 1.74 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-11-25 17:42:49 UTC
(
hide
)
Description:
Bug 23246: Only jump into the 'images' tab HTML5MediaEnabled is set to
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-11-25 17:42:49 UTC
Size:
1.74 KB
patch
obsolete
>From a7eedc68c768dd2c10b1fc5dee398d5c17921d16 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 1 Jul 2019 13:16:42 -0300 >Subject: [PATCH] Bug 23246: Only jump into the 'images' tab HTML5MediaEnabled > is set to > >This patch makes jumping into the third tab happen only if >HTML5MediaEnabled is set to 'both' or 'staff'. > >To test: >- Have HTML5MediaEnabled set to 'opac' or 'not at all' >- Open the detail page of a record with no holdings >=> FAIL: The 'images' tab is selected >- Apply this patch >- Reload >=> SUCCESS: The 'holdings' tab is selected as it should be. >- Sign off :-D > >Sponsored-by: America Numismatic Society >Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index daa9c20bee..8a49989d86 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -936,9 +936,9 @@ > > $(document).ready(function() { > $('#bibliodetails').tabs(); >- [% IF count == 0 %] >- $('#bibliodetails').tabs("option", "active", 3); >- [% END %] >+ [% IF count == 0 and ( Koha.Preference('HTML5MediaEnabled') == 'staff' or Koha.Preference('HTML5MediaEnabled') == 'both' ) %] >+ $('#bibliodetails').tabs("option", "active", 3); >+ [% END %] > $('#search-form').focus(); > $('.thumbnails > li > .remove').click(function() { > var result = confirm(_("Are you sure you want to delete this cover image?")); >-- >2.24.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23246
:
91154
|
91155
|
91361
|
91362
|
95801
|
95802
|
95872
|
95873