Bugzilla – Attachment 95822 Details for
Bug 24117
Patron does not get debarred upon returning overdue item if syspref item-level_itypes is set to biblio and item does not have type information
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix for reported bug
0001-bug-24117-fix.patch (text/plain), 1.63 KB, created by
Pedro Amorim
on 2019-11-26 12:48:16 UTC
(
hide
)
Description:
Proposed fix for reported bug
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2019-11-26 12:48:16 UTC
Size:
1.63 KB
patch
obsolete
>From f25f6b667df4d68a06889b535a266d9c970e9b94 Mon Sep 17 00:00:00 2001 >From: Pedro <pjamorim91@gmail.com> >Date: Tue, 26 Nov 2019 11:42:13 -0100 >Subject: [PATCH] bug 24117 fix > >--- > C4/Circulation.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index ad617c8..69c84ad 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2039,7 +2039,7 @@ sub AddReturn { > > if ( $issue and $issue->is_overdue ) { > # fix fine days >- my ($debardate,$reminder) = _debar_user_on_return( $patron_unblessed, $item_unblessed, dt_from_string($issue->date_due), $return_date ); >+ my ($debardate,$reminder) = _debar_user_on_return( $patron_unblessed, $item_unblessed, $item->effective_itemtype, dt_from_string($issue->date_due), $return_date ); > if ($reminder){ > $messages->{'PrevDebarred'} = $debardate; > } else { >@@ -2238,7 +2238,7 @@ Should only be called for overdue returns > =cut > > sub _debar_user_on_return { >- my ( $borrower, $item, $dt_due, $return_date ) = @_; >+ my ( $borrower, $item, $itemtype, $dt_due, $return_date ) = @_; > > my $branchcode = _GetCircControlBranch( $item, $borrower ); > $return_date //= dt_from_string(); >@@ -2246,7 +2246,7 @@ sub _debar_user_on_return { > my $circcontrol = C4::Context->preference('CircControl'); > my $issuing_rule = Koha::IssuingRules->get_effective_issuing_rule( > { categorycode => $borrower->{categorycode}, >- itemtype => $item->{itype}, >+ itemtype => $itemtype, > branchcode => $branchcode > } > ); >-- >2.7.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24117
:
95820
| 95822