Attachment 95864 Details for Bug 24083 – Bug 24083: Add unit tests

[patch] Bug 24083: Add unit tests

Bug-24083-Add-unit-tests.patch (text/plain), 3.67 KB, created by Andrew Isherwood on 2019-11-28 09:07:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2019-11-28 09:07:22 UTC

Size: 3.67 KB

patch

obsolete

>From fe69e4458c4ae8275e0a8f7bc8a2732ad6cd6312 Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Thu, 28 Nov 2019 09:04:38 +0000
>Subject: [PATCH] Bug 24083: Add unit tests
>
>This patch adds unit tests for unseen renewals
>---
> t/db_dependent/Circulation.t       | 10 +++++++++-
> t/db_dependent/Circulation/issue.t | 13 +++++++++++++
> 2 files changed, 22 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index 2cf83118b6..dfe91e41fb 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -277,7 +277,7 @@ $dbh->do(
> 
> my ( $reused_itemnumber_1, $reused_itemnumber_2 );
> subtest "CanBookBeRenewed tests" => sub {
>-    plan tests => 71;
>+    plan tests => 73;
> 
>     C4::Context->set_preference('ItemsDeniedRenewal','');
>     # Generate test biblio
>@@ -916,6 +916,14 @@ subtest "CanBookBeRenewed tests" => sub {
>     is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
>     is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
> 
>+    # Too many unseen renewals
>+    $dbh->do('UPDATE issuingrules SET unseen_renewals_allowed = 2, renewalsallowed = 10');
>+    $dbh->do('UPDATE issues SET unseen_renewals = 2 where borrowernumber = ? AND itemnumber = ?', undef, ($renewing_borrowernumber, $item_1->itemnumber));
>+    ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
>+    is( $renewokay, 0, 'Cannot renew, 0 unseen renewals allowed');
>+    is( $error, 'too_unseen', 'Cannot renew, returned code is too_unseen');
>+    $dbh->do('UPDATE issuingrules SET norenewalbefore = NULL, renewalsallowed = 0');
>+
>     # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
>     t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');
>     t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
>diff --git a/t/db_dependent/Circulation/issue.t b/t/db_dependent/Circulation/issue.t
>index 81d98bdd5f..5a097bfa04 100644
>--- a/t/db_dependent/Circulation/issue.t
>+++ b/t/db_dependent/Circulation/issue.t
>@@ -32,6 +32,7 @@ use Koha::Checkouts;
> use Koha::Database;
> use Koha::DateUtils;
> use Koha::Holds;
>+use Koha::IssuingRules;
> use Koha::Items;
> use Koha::Library;
> use Koha::Patrons;
>@@ -261,7 +262,19 @@ my $datedue4 = AddRenewal( $opac_renew_issue->{borrowernumber}, $opac_renew_issu
> $stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef,  $opac_renew_issue->{borrowernumber},  $opac_renew_issue->{itemnumber}, "Stavromula" );
> ok( $stat, "Bug 18572 - 'Bug 18572 - OpacRenewalBranch is now respected" );
> 
>+# Unseen rewnewals
>+t::lib::Mocks::mock_preference('UnseenRenewals', 1);
> 
>+# Does an unseen renewal increment the issue's count
>+my ( $unseen_before ) = ( C4::Circulation::GetRenewCount( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber} ) )[3];
>+AddRenewal( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber}, $branchcode_1, undef, undef, 0 );
>+my ( $unseen_after ) = ( C4::Circulation::GetRenewCount( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber} ) )[3];
>+is( $unseen_after, $unseen_before + 1, 'unseen_renewals increments' );
>+
>+# Does a seen renewal reset the unseen count
>+AddRenewal( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber}, $branchcode_1, undef, undef, 1 );
>+my ( $unseen_reset ) = ( C4::Circulation::GetRenewCount( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber} ) )[3];
>+is( $unseen_reset, 0, 'seen renewal resets the unseen count' );
> 
> #Test GetBiblioIssues
> is( GetBiblioIssues(), undef, "GetBiblio Issues without parameters" );
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24083: 95861 | 95862 | 95863 | 95864 | 95865 | 95866 | 95867 | 95868 | 98749 | 98750 | 98751 | 98752 | 98765 | 98766 | 98767 | 98768 | 100244 | 100245 | 100246 | 100247 | 100380 | 100381 | 100382 | 100383 | 100392 | 110607 | 110608 | 110609 | 110610 | 110611 | 111147 | 111148 | 111149 | 111150 | 111151 | 111152 | 111283 | 111284 | 111285 | 111286 | 111287 | 111288 | 111289 | 111290 | 111291 | 111292 | 111293 | 111849 | 111850 | 111851 | 111852 | 111853 | 111854 | 111855 | 111856 | 111857 | 111858 | 111859 | 111860 | 112230 | 112231 | 112232 | 112233 | 112234 | 112235 | 112236 | 112237 | 112238 | 112239 | 112240 | 112241 | 112242 | 112243 | 112410 | 112411 | 112412 | 112413 | 112414 | 112415 | 112416 | 112417 | 112418 | 112419 | 112420 | 112421 | 112422 | 112423 | 113073 | 113074 | 113075 | 113076 | 113077 | 113078 | 113079 | 113080 | 113314 | 113315 | 113484 | 113485 | 113486 | 113487 | 113488 | 113489 | 113490 | 113491 | 113492 | 113493 | 113494 | 113546 | 113556 | 113557 | 113814