Bugzilla – Attachment 95893 Details for
Bug 23974
hours_between and days_between lack tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23974: Add POD for hours_between
Bug-23974-Add-POD-for-hoursbetween.patch (text/plain), 1.38 KB, created by
Martin Renvoize (ashimema)
on 2019-12-02 09:23:22 UTC
(
hide
)
Description:
Bug 23974: Add POD for hours_between
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-12-02 09:23:22 UTC
Size:
1.38 KB
patch
obsolete
>From 582e8da1ac2f57f1ee247dd7d07ea28198203f1a Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 29 Nov 2019 16:44:45 +0000 >Subject: [PATCH] Bug 23974: Add POD for hours_between > >Add a bit of missing POD whilst we're working in here >--- > Koha/Calendar.pm | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > >diff --git a/Koha/Calendar.pm b/Koha/Calendar.pm >index bc8ec82d8e..b227cce081 100644 >--- a/Koha/Calendar.pm >+++ b/Koha/Calendar.pm >@@ -379,7 +379,6 @@ sub hours_between { > } > > return $duration; >- > } > > sub set_daysmode { >@@ -499,7 +498,19 @@ $duration = $calendar->days_between($start_dt, $end_dt); > > Passed two dates returns a DateTime::Duration object measuring the length between them > ignoring closed days. Always returns a positive number irrespective of the >-relative order of the parameters >+relative order of the parameters. >+ >+Note: This routine assumes neither the passed start_dt nor end_dt can be a closed day >+ >+=head2 hours_between >+ >+$duration = $calendar->hours_between($start_dt, $end_dt); >+ >+Passed two dates returns a DateTime::Duration object measuring the length between them >+ignoring closed days. Always returns a positive number irrespective of the >+relative order of the parameters. >+ >+Note: This routine assumes neither the passed start_dt nor end_dt can be a closed day > > =head2 next_open_days > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23974
:
95062
|
95063
|
95064
|
95065
|
95210
|
95211
|
95212
|
95213
|
95214
|
95889
|
95890
|
95891
|
95893
|
95894
|
95895
|
95896
|
96778
|
96779
|
96780
|
96781
|
96782
|
96783
|
96784
|
96785
|
96786
|
97129
|
97130
|
97131
|
97132
|
97133
|
97134
|
97135
|
97136
|
97137