Bugzilla – Attachment 95910 Details for
Bug 23463
Move C4::Items CRUD subroutines to Koha::Item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23463: _do_column_fixes_for_mod dealt with integer location and timestamp moved
Bug-23463-docolumnfixesformod-dealt-with-integer-l.patch (text/plain), 2.02 KB, created by
Jonathan Druart
on 2019-12-02 12:04:53 UTC
(
hide
)
Description:
Bug 23463: _do_column_fixes_for_mod dealt with integer location and timestamp moved
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-12-02 12:04:53 UTC
Size:
2.02 KB
patch
obsolete
>From c7dd27dcec9315246404b2f90b184d5a0ff27e15 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 6 Aug 2019 11:12:31 -0500 >Subject: [PATCH] Bug 23463: _do_column_fixes_for_mod dealt with integer > location and timestamp moved > >That's done in Koha::Item->store, and Koha::Object->store for integers. >--- > C4/Items.pm | 44 -------------------------------------------- > 1 file changed, 44 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 6bd16b718a..044216b856 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -1271,50 +1271,6 @@ sub _set_derived_columns_for_add { > } > } > >-=head2 _do_column_fixes_for_mod >- >- _do_column_fixes_for_mod($item); >- >-Given an item hashref containing one or more >-columns to modify, fix up certain values. >-Specifically, set to 0 any passed value >-of C<notforloan>, C<damaged>, C<itemlost>, or >-C<withdrawn> that is either undefined or >-contains the empty string. >- >-=cut >- >-sub _do_column_fixes_for_mod { >- my $item = shift; >- >- if (exists $item->{'notforloan'} and >- (not defined $item->{'notforloan'} or $item->{'notforloan'} eq '')) { >- $item->{'notforloan'} = 0; >- } >- if (exists $item->{'damaged'} and >- (not defined $item->{'damaged'} or $item->{'damaged'} eq '')) { >- $item->{'damaged'} = 0; >- } >- if (exists $item->{'itemlost'} and >- (not defined $item->{'itemlost'} or $item->{'itemlost'} eq '')) { >- $item->{'itemlost'} = 0; >- } >- if (exists $item->{'withdrawn'} and >- (not defined $item->{'withdrawn'} or $item->{'withdrawn'} eq '')) { >- $item->{'withdrawn'} = 0; >- } >- if (exists $item->{location} >- and $item->{location} ne 'CART' >- and $item->{location} ne 'PROC' >- and not $item->{permanent_location} >- ) { >- $item->{'permanent_location'} = $item->{'location'}; >- } >- if (exists $item->{'timestamp'}) { >- delete $item->{'timestamp'}; >- } >-} >- > =head2 _get_single_item_column > > _get_single_item_column($column, $itemnumber); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23463
:
95899
|
95900
|
95901
|
95902
|
95903
|
95904
|
95905
|
95906
|
95907
|
95908
|
95909
|
95910
|
95911
|
95912
|
95913
|
95914
|
95915
|
95916
|
95917
|
95918
|
95919
|
95920
|
95921
|
95922
|
95923
|
95925
|
96145
|
97895
|
97896
|
97897
|
97898
|
97899
|
97900
|
97901
|
97902
|
97903
|
97904
|
97905
|
97906
|
97907
|
97908
|
97909
|
97910
|
97911
|
97912
|
97913
|
97914
|
97915
|
97916
|
97917
|
97918
|
97919
|
97920
|
97921
|
101151
|
101152
|
101153
|
101154
|
101156
|
101157
|
101158
|
101161
|
101163
|
101165
|
101167
|
101169
|
101170
|
101171
|
101172
|
101173
|
101174
|
101175
|
101176
|
101177
|
101178
|
101179
|
101180
|
101181
|
101182
|
101183
|
101184
|
101185
|
101186
|
101188
|
101189
|
101190
|
101191
|
101192
|
101193
|
101194
|
101195
|
101196
|
101197
|
101246
|
101247
|
101248
|
101249
|
101250
|
101251
|
101252
|
101253
|
101254
|
101255
|
101256
|
101257
|
101258
|
101259
|
101260
|
101261
|
101262
|
101263
|
101264
|
101265
|
101266
|
101267
|
101268
|
101269
|
101270
|
101271
|
101272
|
101273
|
101274
|
101275
|
101276
|
101277
|
101278
|
101279
|
101280
|
101281
|
101282
|
101283
|
101284
|
101413
|
101414
|
101415
|
101416
|
101432
|
101476
|
102071
|
103129
|
113581