Attachment 95942 Details for Bug 14543 – Bug 14543: Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[patch] Bug 14543: Order lines updated that have a tax rate not in gist will have tax rate set to 0!

Bug-14543-Order-lines-updated-that-have-a-tax-rate.patch (text/plain), 3.12 KB, created by Jonathan Druart on 2019-12-03 10:57:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-12-03 10:57:47 UTC

Size: 3.12 KB

patch

obsolete

>From 5ac1ca1782830e917c8ddb03811ba841f3db52a7 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 16 Jul 2015 12:14:42 -0400
>Subject: [PATCH] Bug 14543: Order lines updated that have a tax rate not in
> gist will have tax rate set to 0!
>
>If the tax rate for a given order line has been removed from the system
>preference gist, that tax rate will show in the pulldown as 0. If a
>librarian then saves the order line the original tax rate will be
>overwritten with 0%!
>
>Test Plan:
>1) Find an order line
>2) Remove the tax rate set for that order line from the syspref gist
>3) Edit the order line
>4) Note the tax rate is 0
>5) Apply this patch
>6) Edit the order line
>7) Note the tax rate now displays with a warning
>---
> .../prog/en/modules/acqui/neworderempty.tt.rej     | 32 ++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
> create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt.rej
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt.rej b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt.rej
>new file mode 100644
>index 0000000000..87d9135e9c
>--- /dev/null
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt.rej
>@@ -0,0 +1,32 @@
>+diff a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt	(rejected hunks)
>+@@ -556,14 +556,23 @@ $(document).ready(function()
>+                     [% ELSE %]
>+                         <label for="gstrate">Tax rate: </label>
>+                         <select name="gstrate" id="gstrate" onchange="updateCosts();">
>+-                        [% FOREACH gst IN gst_values %]
>+-                          [% IF ( gst.option == gstrate ) %]
>+-                            <option value="[% gst.option %]" selected="selected">[% gst.option * 100 %]%</option>
>+-                          [% ELSE %]
>+-                            <option value="[% gst.option %]">[% gst.option * 100 %]%</option>
>+-                          [% END %]
>+-                        [% END %]
>++                            [% SET gst_found = 0 %]
>++
>++                            [% FOREACH gst IN gst_values %]
>++                              [% IF ( gst.option == gstrate ) %]
>++                                <option value="[% gst.option %]" selected="selected">[% gst.option * 100 %]%</option>
>++                                [% SET gst_found = 1 %]
>++                              [% ELSE %]
>++                                <option value="[% gst.option %]">[% gst.option * 100 %]%</option>
>++                              [% END %]
>++                            [% END %]
>++
>++                            [% IF !gst_found %]
>++                                <option value="[% gstrate %]" selected="selected">[% gstrate * 100 %]%</option>
>++                            [% END %]
>+                         </select>
>++
>++                        [% IF !gst_found %]<span class="required">Tax rate not defined in system preference gist!</span>[% END %]
>+                     [% END %]
>+                 [% ELSE %]
>+                     <input type="hidden" name="gstrate" value="0" />
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 14543: 41033 | 95942 | 95943 | 105181 | 105404 | 105629 | 105630