Bugzilla – Attachment 95988 Details for
Bug 23767
Spent and Ordered total values don't include child funds on acqui-home
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23767: Don't calculate 'Total available'
Bug-23767-Dont-calculate-Total-available.patch (text/plain), 2.31 KB, created by
Séverine Queune
on 2019-12-04 10:47:56 UTC
(
hide
)
Description:
Bug 23767: Don't calculate 'Total available'
Filename:
MIME Type:
Creator:
Séverine Queune
Created:
2019-12-04 10:47:56 UTC
Size:
2.31 KB
patch
obsolete
>From a30123654fa3342cbf401ab3dbf1ae9ed68fe728 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 26 Nov 2019 19:41:23 +0000 >Subject: [PATCH] Bug 23767: Don't calculate 'Total available' >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The acqui-home page is meant to be a simple view of the budgets. For details you should lok at aqbudgets.pl ( i.e. click on a budget) > >The total available column isn't easy to calculate - it depends on child funds - trying to calculate what a top level fund has left depends on the values of the child funds. When searching the table and limiting rows you lose the values form the children. > >On acqbudgets.pl we solve this with the Base-level/Total available columns, and we don't total base-level on that page at all. 'Total available' on acqui-home equals the 'Base level' on the other page. > >Removing a recalculated total is the simplest answer here, otherwise we must add complexity to this view. > >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt >index 02bcf6b..8b75de4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt >@@ -151,11 +151,7 @@ > </a> > </td> > <td class="data"> >- [% IF loop_budge.budget_parent_id %] > [% loop_budge.budget_avail | $Price %] >- [% ELSE %] >- <span class="total_amount">[% loop_budge.budget_avail | $Price %]</span> >- [% END %] > </td> > </tr> > [% END %] >@@ -212,7 +208,7 @@ > }, > "footerCallback": function ( row, data, start, end, display ) { > var api = this.api(), data; >- footer_column_sum( api, [ 6, 7, 8, 9 ] ); >+ footer_column_sum( api, [ 6, 7, 8 ] ); > }, > "aoColumnDefs": [ > { "bVisible": false, "aTargets": [ 0, 1 ] }, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23767
:
93828
|
94811
|
95334
|
95335
|
95840
|
95841
|
95987
|
95988
|
98618
|
116258
|
116284
|
116285
|
116701
|
116702