Attachment 96009 Details for Bug 24124 – Bug 24124: Cannot select authorities in batch deletion tool in Chrome

[patch] Bug 24124: Cannot select authorities in batch deletion tool in Chrome

Bug-24124-Cannot-select-authorities-in-batch-delet.patch (text/plain), 2.67 KB, created by Jonathan Druart on 2019-12-05 11:06:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-12-05 11:06:44 UTC

Size: 2.67 KB

patch

obsolete

>From 44cb4937320bb5474f787fcc2181b0c972cb1243 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 2 Dec 2019 15:14:33 +0000
>Subject: [PATCH] Bug 24124: Cannot select authorities in batch deletion tool
> in Chrome
>
>This patch adds some inline CSS to force clearing on some elements in
>the forms for batch record modification and deletion. The problem with
>selecting the "Authorities" radio button stemmed from the fact that
>non-clearing floats caused elements to invisibly overlap in the form.
>
>To test, apply the patch and test both batch record modification and
>batch record deletion. Upon selecting the "Authorities" radio button in
>each case the "Select a list of records" tab should disappear. Selecting
>the "Biblios" option should re-display the tab.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt | 4 +---
> .../intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt  | 2 +-
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
>index 232cfab014..4e1beada06 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
>@@ -65,9 +65,7 @@
>         </ol>
>       </fieldset>
> 
>-      <br><br>
>-
>-      <div id="batch_del_form" class="toptabs">
>+      <div id="batch_del_form" class="toptabs" style="clear:both">
>         <ul>
>           <li><a href="#uploadfile_tab">Upload a file</a></li>
>           [% IF lists.count %]<li id="show_list_option"><a href="#shelves_tab">Select a list of records</a></li>[% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>index 53762988eb..95d8919871 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>@@ -71,7 +71,7 @@
> 
>                             <br><br>
> 
>-                            <div id="batch_mod_form" class="toptabs">
>+                            <div id="batch_mod_form" class="toptabs" style="clear:both">
>                                 <ul>
>                                     <li><a href="#uploadfile_tab">Upload a file</a></li>
>                                         [% IF lists.count %]<li id="show_list_option"><a href="#shelves_tab">Select a list of records</a></li>[% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24124: 95926 | 95985 | 96009 | 96013