Attachment 96035 Details for Bug 21270 – Bug 21270: "Not finding what you're looking for" displaying uselessly

[patch] Bug 21270: "Not finding what you're looking for" displaying uselessly

Bug-21270-Not-finding-what-youre-looking-for-displ.patch (text/plain), 2.10 KB, created by Andrew Isherwood on 2019-12-05 12:29:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2019-12-05 12:29:46 UTC

Size: 2.10 KB

patch

obsolete

>From 38e3113c6c702f3ad73765b7852622d41010bf9a Mon Sep 17 00:00:00 2001
>From: Blou <philippe.blouin@inlibro.com>
>Date: Fri, 24 Aug 2018 11:46:54 -0400
>Subject: [PATCH] Bug 21270: "Not finding what you're looking for" displaying
> uselessly
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled.
>
>Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user.
>
>Just taunting them...
>
>TEST:
>0) Set IllModule to true, AnonSuggestions to false.
>1) Without login, just to an OPAC search.  At the bottom will be a nice string laughing at your failed search
>2) Apply the patch.
>3) Problem at 1) is fixed.
>4) Login to validate that ILL link now appear.
>5) Modify combination of IllModule and AnonSuggestions to validate links appearing.
>
>Patch applies and functions as described.
>Signed-off-by: Dilan JohnpullÃ© <dilan@calyx.net.au>
>Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>index aa1f27eebc..05818aca5f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>@@ -599,7 +599,7 @@
> 
>                     [% END # / IF total %]
> 
>-                    [% IF Koha.Preference( 'suggestion' ) == 1 && ( Koha.Preference( 'AnonSuggestions' ) == 1 || loggedinusername || Koha.Preference( 'ILLModule' ) == 1 )   %]
>+                    [% IF Koha.Preference( 'suggestion' ) == 1 && ( Koha.Preference( 'AnonSuggestions' ) == 1 || loggedinusername )   %]
>                         <div class="suggestion">
>                             Not finding what you're looking for?
>                             <ul>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21270: 78141 | 78239 | 95807 | 96034 | 96035 | 96036 | 96037 | 96059 | 96060