Bugzilla – Attachment 96060 Details for
Bug 21270
"Not finding what you're looking" display needs to be fixed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21270: Display "Make an Interlibrary loan request" even if "suggestions" is turned off
Bug-21270-Display-Make-an-Interlibrary-loan-reques.patch (text/plain), 2.88 KB, created by
Marcel de Rooy
on 2019-12-06 09:46:57 UTC
(
hide
)
Description:
Bug 21270: Display "Make an Interlibrary loan request" even if "suggestions" is turned off
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-12-06 09:46:57 UTC
Size:
2.88 KB
patch
obsolete
>From e26ff8bde99854ae70634e347b6e05ecfb39e736 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 5 Dec 2019 13:19:20 +0100 >Subject: [PATCH] Bug 21270: Display "Make an Interlibrary loan request" even > if "suggestions" is turned off >Content-Type: text/plain; charset=utf-8 > >Test plan: >- Turn off "suggestions" >- Turn on "ILLModule" >=> When logged in you should see the "Make an Interlibrary loan request" > >- Turn on "suggestions" >- Turn off "ILLModule" >=> When logged in you should see the "Make a purchase suggestion" > >- Turn on "suggestions" >- Turn on "ILLModule" >=> When logged in you should see both links. > >- Turn off "suggestions" >- Turn off "ILLModule" >=> You should not see the "Not finding what you're looking for?" block > >- Turn on "suggestions" >- Turn on AnonSuggestions >=> You should see the "Make a purchase suggestion" even when logged out > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 05818aca5f..2ad3ee9d68 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -599,14 +599,15 @@ > > [% END # / IF total %] > >- [% IF Koha.Preference( 'suggestion' ) == 1 && ( Koha.Preference( 'AnonSuggestions' ) == 1 || loggedinusername ) %] >+ [%# Display "Not finding what you're looking for" for suggestion or ILL %] >+ [% IF Koha.Preference( 'suggestion' ) == 1 && ( Koha.Preference( 'AnonSuggestions' ) == 1 || loggedinusername ) || ( Koha.Preference( 'ILLModule' ) == 1 && loggedinusername ) %] > <div class="suggestion"> > Not finding what you're looking for? > <ul> >- [% IF Koha.Preference( 'AnonSuggestions' ) == 1 %] >- <li>Make a <a href="/cgi-bin/koha/opac-suggestions.pl?op=add">purchase suggestion</a></li> >- [% ELSE %] >- [% IF ( loggedinusername ) %] >+ [% IF Koha.Preference( 'suggestion' ) == 1 %] >+ [% IF Koha.Preference( 'AnonSuggestions' ) == 1 %] >+ <li>Make a <a href="/cgi-bin/koha/opac-suggestions.pl?op=add">purchase suggestion</a></li> >+ [% ELSIF loggedinusername %] > <li>Make a <a href="/cgi-bin/koha/opac-suggestions.pl?op=add">purchase suggestion</a></li> > [% END %] > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21270
:
78141
|
78239
|
95807
|
96034
|
96035
|
96036
|
96037
|
96059
| 96060