Bugzilla – Attachment 96074 Details for
Bug 24186
maxFine can break fine reductions in updateFine
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Add Debugging
Add-Debugging.patch (text/plain), 1.38 KB, created by
Martin Renvoize (ashimema)
on 2019-12-06 16:55:24 UTC
(
hide
)
Description:
Add Debugging
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-12-06 16:55:24 UTC
Size:
1.38 KB
patch
obsolete
>From 38f1047712eb84076d608827fb7f6eba32f3364d Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 6 Dec 2019 16:54:34 +0000 >Subject: [PATCH] Add Debugging > >https://bugs.koha-community.org/show_bug.cgi?id=24186 >--- > C4/Overdues.pm | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/C4/Overdues.pm b/C4/Overdues.pm >index 64046aee9e..9fab0ab923 100644 >--- a/C4/Overdues.pm >+++ b/C4/Overdues.pm >@@ -510,6 +510,8 @@ accountlines table of the Koha database. > sub UpdateFine { > my ($params) = @_; > >+ warn "\n\n"; >+ > my $issue_id = $params->{issue_id}; > my $itemnum = $params->{itemnumber}; > my $borrowernumber = $params->{borrowernumber}; >@@ -549,12 +551,16 @@ sub UpdateFine { > next; > } > } >+ warn "adding " . $overdue->amountoutstanding . "\n"; > $total_amount_other += $overdue->amountoutstanding; > } > > if ( my $maxfine = C4::Context->preference('MaxFine') ) { >+ warn "in maxFine with $maxfine\n"; > my $maxIncrease = $maxfine - $total_amount_other; >+ warn "maxIncrease = $maxIncrease\n"; > return if $maxIncrease <= 0.00; >+ warn "maxIncrease more than 0.00\n"; > if ($accountline) { > if ( ( $amount - $accountline->amount ) > $maxIncrease ) { > my $new_amount = $accountline->amount + $maxIncrease; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24186
:
96073
| 96074