Attachment 96116 Details for Bug 24191 – Bug 24191: Make objects.search pass to_model to dbic_merge_sorting

[patch] Bug 24191: Make objects.search pass to_model to dbic_merge_sorting

Bug-24191-Make-objectssearch-pass-tomodel-to-dbicm.patch (text/plain), 1.40 KB, created by Tomás Cohen Arazi (tcohen) on 2019-12-09 18:50:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2019-12-09 18:50:40 UTC

Size: 1.40 KB

patch

obsolete

>From e5502415d287c3768c8ea50eab6bbb65d9a659cb Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 9 Dec 2019 15:31:36 -0300
>Subject: [PATCH] Bug 24191: Make objects.search pass to_model to
> dbic_merge_sorting
>
>This patch makes objects.search pass the to_mode method reference so it
>can be used to map API attributes to column names when building the
>sorting portion of the query.
>
>To test:
>1. Apply the regression tests on this patchset
>2. Run:
>  $ kshell
> k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t
>=> FAIL: Tests fail!
>3. Apply the rest of the patchset
>4. Run:
> k$ prove t/Koha/REST/Plugin/Query.t
>=> SUCCESS: Tests pass! changes to the methods work as expected!
>5. Run:
> k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t
>=> SUCCESS: Tests pass!
>6. Sign off :-D
>
>Sponsored-by: ByWater Solutions
>---
> Koha/REST/Plugin/Objects.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/REST/Plugin/Objects.pm b/Koha/REST/Plugin/Objects.pm
>index 3653f914ef..3d314a784e 100644
>--- a/Koha/REST/Plugin/Objects.pm
>+++ b/Koha/REST/Plugin/Objects.pm
>@@ -60,7 +60,8 @@ sub register {
>             $c->dbic_merge_sorting(
>                 {
>                     attributes => $attributes,
>-                    params     => $reserved_params
>+                    params     => $reserved_params,
>+                    to_model   => $to_model
>                 }
>             );
> 
>-- 
>2.24.0

Actions: View | Diff | Splinter Review

Attachments on bug 24191: 96114 | 96115 | 96116 | 96117 | 96118 | 96119 | 96133 | 96134 | 96135