Bugzilla – Attachment 96155 Details for
Bug 21761
Koha::Object supports passing through 'update' which means we can side step 'set' + 'store'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21761: Do not call $self->store in ->set_password
Bug-21761-Do-not-call-self-store-in--setpassword.patch (text/plain), 1.05 KB, created by
Marcel de Rooy
on 2019-12-10 13:33:42 UTC
(
hide
)
Description:
Bug 21761: Do not call $self->store in ->set_password
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-12-10 13:33:42 UTC
Size:
1.05 KB
patch
obsolete
>From 828b064c2780d7059553f776aad5d3176a448c17 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 10 Dec 2019 10:50:58 +0100 >Subject: [PATCH] Bug 21761: Do not call $self->store in ->set_password >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Patron.pm | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index 8e501fcfb1..2de2965e7f 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -770,11 +770,11 @@ sub set_password { > } > > my $digest = Koha::AuthUtils::hash_password($password); >- $self->update( >- { password => $digest, >- login_attempts => 0, >- } >- ); >+ >+ # We do not want to call $self->store and retrieve password from DB >+ $self->password($digest); >+ $self->login_attempts(0); >+ $self->SUPER::store; > > logaction( "MEMBERS", "CHANGE PASS", $self->borrowernumber, "" ) > if C4::Context->preference("BorrowersLog"); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21761
:
86017
|
90914
|
95947
|
96136
|
96154
| 96155