Attachment 96238 Details for Bug 24235 – Bug 24235: Do not use hardcoded message_name

[patch] Bug 24235: Do not use hardcoded message_name

Bug-24235-Do-not-use-hardcoded-messagename.patch (text/plain), 1.08 KB, created by Josef Moravec on 2019-12-13 08:20:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2019-12-13 08:20:12 UTC

Size: 1.08 KB

patch

obsolete

>From 41f834b859dfe6d702dede4afe0d668645186506 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Fri, 13 Dec 2019 09:04:22 +0100
>Subject: [PATCH] Bug 24235: Do not use hardcoded message_name
>
>Test plan:
>0) Do not apply the patch and reproduce the bug
>    - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower
>    - Sms version of DUEDGST is never generated into the message queue.
>1) Apply the patch
>2) Ensure that the bug is fixed
>---
> misc/cronjobs/advance_notices.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl
>index af97c4103b..40e7cc7583 100755
>--- a/misc/cronjobs/advance_notices.pl
>+++ b/misc/cronjobs/advance_notices.pl
>@@ -549,7 +549,7 @@ sub send_digests {
>             C4::Members::Messaging::GetMessagingPreferences(
>                 {
>                     borrowernumber => $borrowernumber,
>-                    message_name   => 'advance_notice'
>+                    message_name   => $params->{message_name}
>                 }
>             );
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24235: 96238 | 96240 | 96279 | 96283 | 96308