Bugzilla – Attachment 96243 Details for
Bug 23800
Batch modification tool orders items by barcode incremental by default (regression to 17.11)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23800: (QA follow-up) Remove useless line
Bug-23800-QA-follow-up-Remove-useless-line.patch (text/plain), 1.18 KB, created by
Marcel de Rooy
on 2019-12-13 10:04:25 UTC
(
hide
)
Description:
Bug 23800: (QA follow-up) Remove useless line
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-12-13 10:04:25 UTC
Size:
1.18 KB
patch
obsolete
>From bbaf529e5fc12e73231c9b99f3ceb30c405d08a2 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 13 Dec 2019 10:03:20 +0000 >Subject: [PATCH] Bug 23800: (QA follow-up) Remove useless line >Content-Type: text/plain; charset=utf-8 > >The lines with my @barcodes makes no sense anymore. > >Test plan: >Test with a barcode file. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > tools/batchMod.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index 124d6f0b6a..9ed3301471 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -264,7 +264,6 @@ if ($op eq "show"){ > @contentlist = uniq @contentlist; > # Note: adding lc for case insensitivity > my %itemdata = map { lc($_->{barcode}) => $_->{itemnumber} } @{ Koha::Items->search({ barcode => \@contentlist }, { columns => [ 'itemnumber', 'barcode' ] } )->unblessed }; >- my @barcodes = grep { exists $itemdata{lc $_} } @contentlist; > @itemnumbers = map { exists $itemdata{lc $_} ? $itemdata{lc $_} : () } @contentlist; > @notfoundbarcodes = grep { !exists $itemdata{lc $_} } @contentlist; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23800
:
93987
|
94032
|
94033
|
94034
|
94353
|
94354
|
95252
|
95659
|
96241
|
96242
| 96243